refactor!: New separate entry modules for each component. #1351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
-darken the opacity to improve readability -update text color of disabled chips to look non-selectable -remove the X icon to further confer that this chip is read-only Co-authored-by: Michael Dill <[email protected]>
* Expanding non-ideal-state for use case with novo-loading * Expanding non-ideal-state for use case with novo-loading * Minor structure cleanup * Changed message on example
bvkimball
changed the title
bvkimball
changed the title
bvkimball
added
breaking change
requires discussion
|
Visit the preview URL for this PR (updated for commit 58a142d): https://novo-elements--pr1351-f-ng-packager-3-9rq8qbzq.web.app (expires Mon, 24 Oct 2022 18:07:51 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: f1783e19c2444272095017dd8ba433fff0ee3f61 |
|
$GITHUB_STEP_SUMMARY |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding ng-packagr build files to each module to create separate tree-shakable imports. This make the project cleaner and leaner. woot! 🎉
Styles are loaded only if import that module
Because half of our components use angulars
styleUrlsto compile and load the scss for that component and the other half built it in a deployable novo-elements scss, we needed to cleanup this work one way or the other. Both have merits but using angular emulated encapsulation will help us have cleaner styles that don't bleed too much. Also loading as part of the component means we wont load component styles we don't use. Woot! 🎉New Design Tokens
We expanded upon the design token library as part of this work to add theme-able tokens for the design system, to support Novo and Talent themes... but also custom themes or customer overrides! woot! 🎉 This work is still inflight but the token naming conventions and component specific overrides are stable enough for a preview.
No More Sass Variables
We are tripling down on css-variables, they offer runtime support for themes and are pretty awesome. using css variables with SASS/SCSS is pretty straight forward, mixins have been moved or added to
novo-design-tokensto help utilize the variables.Incomplete work: