Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(NonIdealState): Non Ideal Loading #1334

Merged
merged 4 commits into from
Jul 27, 2022
Merged

feat(NonIdealState): Non Ideal Loading #1334

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e0342c1
Expanding non-ideal-state for use case with novo-loading
antonyw89 Jul 26, 2022
238ea7c
Expanding non-ideal-state for use case with novo-loading
antonyw89 Jul 26, 2022
af63ee6
Minor structure cleanup
antonyw89 Jul 26, 2022
b255be8
Changed message on example
antonyw89 Jul 27, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions projects/novo-elements/src/elements/non-ideal-state/NonIdealState.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,9 @@ import { Component, HostBinding, Input } from '@angular/core';
styleUrls: ['./NonIdealState.scss'],
template: `
<novo-icon class="novo-non-ideal-state-icon" *ngIf="icon" [color]="theme">{{ icon }}</novo-icon>
<ng-content select="novo-icon,novo-loading,novo-avatar"></ng-content>
<novo-title class="novo-non-ideal-state-title" *ngIf="title" marginBefore>{{ title }}</novo-title>
<ng-content select="novo-title"></ng-content>
<novo-text *ngIf="description" block marginBefore marginAfter>{{ description }}</novo-text>
<ng-content></ng-content>
`,
Expand Down
1 change: 1 addition & 0 deletions projects/novo-examples/src/components/non-ideal-state/non-ideal-state-examples.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,3 +14,4 @@ Basic use-case is to display an icon, message, and reason for this state to occu
The call to action doesn't necessarily need to be a button, for example:

<code-example example="non-ideal-state-search-usage"></code-example>
<code-example example="non-ideal-state-loading-usage"></code-example>
1 change: 1 addition & 0 deletions projects/novo-examples/src/components/non-ideal-state/non-ideal-state-loading-usage/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
export * from './non-ideal-state-loading-usage-example';
3 changes: 3 additions & 0 deletions ...s/non-ideal-state/non-ideal-state-loading-usage/non-ideal-state-loading-usage-example.css
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
span[tooltip]{
margin-left: 10px;
}
6 changes: 6 additions & 0 deletions .../non-ideal-state/non-ideal-state-loading-usage/non-ideal-state-loading-usage-example.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
<novo-non-ideal-state>
<novo-loading></novo-loading>
<novo-text lineLength="large" marginAfter>We are currently experiencing technical difficulites and your wait time is
taking a bit longer than expected. Please be patient. </novo-text>
antonyw89 marked this conversation as resolved.
Show resolved Hide resolved
<button theme="primary" icon="refresh-o">Refresh</button>
</novo-non-ideal-state>
11 changes: 11 additions & 0 deletions ...ts/non-ideal-state/non-ideal-state-loading-usage/non-ideal-state-loading-usage-example.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
import { Component } from '@angular/core';

/**
* @title Non Ideal State Alt Usage
*/
@Component({
selector: 'non-ideal-state-loading-usage-example',
templateUrl: './non-ideal-state-loading-usage-example.html',
styleUrls: ['./non-ideal-state-loading-usage-example.css'],
})
export class NonIdealStateLoadingUsageExample {}
1 change: 1 addition & 0 deletions projects/novo-examples/src/examples.routes.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2306,6 +2306,7 @@ export class NonIdealStateDevelopPage {
<p><code-example example="non-ideal-state-usage"></code-example></p>
<p>The call to action doesn't necessarily need to be a button, for example:</p>
<p><code-example example="non-ideal-state-search-usage"></code-example></p>
<p><code-example example="non-ideal-state-loading-usage"></code-example></p>
`,
host: { class: 'markdown-page' }
})
Expand Down