Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(): some remaining prep work for the upcoming typescript 4 upgrade #1268

Merged
merged 2 commits into from
Mar 23, 2022
Merged

refactor(): some remaining prep work for the upcoming typescript 4 upgrade #1268

merged 2 commits into from
Mar 23, 2022

Conversation

dvoegelin
Copy link
Collaborator

@dvoegelin dvoegelin commented Mar 15, 2022 •
edited
Loading

…grade

Description

Missed a few spots in !1266.
Updating a few more .value calls to .getRawValue() on NovoFormGroup objects, and adding some missing getters.

Verify that...

  • [/] Any related demos were added and npm start and npm run build still works
  • [/] New demos work in Safari, Chrome and Firefox
  • [/] npm run lint passes
  • [/] npm test passes and code coverage is increased
  • [/] npm run build still works

Bullhorn Internal Developers

  • Run Novo Automation
Screenshots

@hiqbal01 hiqbal01 changed the base branch from master to next March 21, 2022 18:45
@dvoegelin dvoegelin merged commit 89a45b1 into next Mar 23, 2022
@dvoegelin dvoegelin deleted the typescript4-b branch March 23, 2022 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@dvoegelin