fix(Version): Removed version dialog and moved version to title (#50)

bullhorn · Jun 12, 2018 · 7c59c21 · 7c59c21
1 parent 53f22b9
commit 7c59c21
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 22 deletions.
diff --git a/main-process/menu.ts b/main-process/menu.ts
@@ -1,5 +1,4 @@
-import { app, dialog, shell } from 'electron';
-import { glob } from 'glob';
+import { app, shell } from 'electron';
 import * as path from 'path';
 
 export let menuTemplate: Electron.MenuItemConstructorOptions[] = [
@@ -91,25 +90,6 @@ export let menuTemplate: Electron.MenuItemConstructorOptions[] = [
     label: 'Help',
     role: 'help',
     submenu: [{
-      label: 'About',
-      click: (item, focusedWindow) => {
-        if (focusedWindow) {
-          const dataloaderDir: string = path.join(app.getAppPath(), 'dataloader').replace('app.asar', 'app.asar.unpacked');
-          const jarFiles: string[] = glob.sync('dataloader-*.jar', { cwd: dataloaderDir });
-          let version: string = jarFiles.length ? path.basename(jarFiles[0], '.jar').split('-')[1] : 'missing';
-          const options: Electron.MessageBoxOptions = {
-            type: 'info',
-            title: 'About Data Loader',
-            buttons: ['Close'],
-            message: `Data Loader Version: ${version}`,
-          };
-          dialog.showMessageBox(focusedWindow, options, () => {
-          });
-        }
-      },
-    }, {
-      type: 'separator',
-    }, {
       label: 'Wiki',
       click: () => {
         shell.openExternal('http://github.com/bullhorn/dataloader/wiki');

diff --git a/src/index.html b/src/index.html
@@ -2,7 +2,7 @@
 <html lang="en">
 <head>
   <meta charset="utf-8">
-  <title>Bullhorn DataLoader</title>
+  <title>Bullhorn Data Loader v0.3.3 (CLI v3.8.0)</title>
   <base href="/">
 
   <meta name="viewport" content="width=device-width, initial-scale=1">