-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(lib): Updated Generation to EntityModelStreamer... #69
base: master
Are you sure you want to change the base?
Conversation
…n Jenkins nightly
…be read via the API
…be read via the API
case "Timestamp": | ||
data.properties.push({ | ||
name: field.fieldName, | ||
type: "Date", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Dates are not actually represented as Date objects in REST - they are returned as the millisecond timestamp, which should be of type number
, not Date
.
case "byte[]": | ||
data.properties.push({ | ||
name: field.fieldName, | ||
type: "Strings", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The only fields that require the Strings
type of string or string[]
are fields that start with customText. Configuring a field outside of a custom text field to be a multi-value string array in field maps would be either extremely rare, or a misconfig. For instance, the status string field could be configured to be a multi-value by a customer, but that would break any workflows that rely on status being a single value string. We can add logic that only applies the Strings
to fields that are of the format: customText[n]
. We don't need to apply this to customTextBlock[n]
because those fields should not be configured to be multi-value - they are text areas or html editor blocks.
Probably need to run in Jenkins nightly and do a diff against the results, or open PR if there are changes.