Delete unneeded comment (xray-rails) in Gemfile #271
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Don't think we can do this yet, it looks like the compatibility fix PR is still open on xray-rails brentd/xray-rails#108 |
|
Okay, I guess I'm just confused as to why it's commented out. Are we leaving it just in case developers want to use xray? |
|
@gazayas Ah, yes, this is safe to remove because we got rid of X-ray as a dependency! We just use the regular Rails annotations now! |
|
@andrewculver Thanks for clarifying 🙌 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm assuming we don't need these lines anymore since we merged in nice_partials#28
Thanks @kaspth!