Calculate new repository link from ssh path in configure script #1614
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Closing in favor of #1727 |
jagthedrummer
approved these changes
Oct 30, 2024
There was a problem hiding this comment.
Thanks, @gazayas, this looks great! (Sorry it took me so long to get to it. 😬 )
|
@jagthedrummer No problem, thanks for giving it a look! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1607.
I figured we didn't want to entirely get rid of the
askmethods here in case developers decide not to setup their project with GitHub. I tested the configure script against a personal repository of mine so it should work, but you can pull it down with this branch if you want to check it out: