stable

lib/toggleable/feature_toggler.rb

@@ -16,8 +16,9 @@ def register(key)
       features << key
     end
 
-    def available_features
-      keys.slice(*features)
+    def available_features(memoize: Toggleable.configuration.use_memoization)
+      available_features = memoize ? memoized_keys : keys
+      available_features.slice(*features)
     end
 
     def mass_toggle!(mapping, actor: nil)
@@ -31,6 +32,16 @@ def keys
       Toggleable.configuration.storage.hgetall(NAMESPACE)
     end
 
+    def memoized_keys
+      return @_memoized_keys if defined?(@_memoized_keys) && !read_expired?
+      @_last_read_at = Time.now.localtime
+      @_memoized_keys = Toggleable.configuration.storage.hgetall(NAMESPACE)
+    end
+
+    def read_expired?
+      @_last_read_at < Time.now.localtime - Toggleable.configuration.expiration_time
+    end
+
     def log_changes(mapping, actor)
       previous_values = available_features
       mapping.each do |key, val|

spec/toggleable/feature_toggler_spec.rb

@@ -15,20 +15,50 @@
     end
 
     describe '#available_features' do
-      let(:keys) {
-        {
-          'active_key' => 'true',
-          'inactive_key' => 'false',
-          'unavailable_key' => 'true'
+      context 'without memoize' do
+        let(:keys) {
+          {
+            'active_key' => 'true',
+            'inactive_key' => 'false',
+            'unavailable_key' => 'true'
+          }
         }
-      }
 
-      before do
-        allow(subject).to receive(:keys).and_return(keys)
-        allow(subject).to receive(:features).and_return(['active_key', 'inactive_key'])
+        before do
+          allow(subject).to receive(:keys).and_return(keys)
+          allow(subject).to receive(:features).and_return(['active_key', 'inactive_key'])
+        end
+
+        it { expect(subject.available_features).to eq({ 'active_key' => 'true', 'inactive_key' => 'false' }) }
       end
 
-      it { expect(subject.available_features).to eq({ 'active_key' => 'true', 'inactive_key' => 'false' }) }
+      context 'with memoize' do
+        let(:keys) {
+          {
+            'active_key' => 'true',
+            'inactive_key' => 'false',
+            'unavailable_key' => 'true'
+          }
+        }
+
+        let(:updated_keys) {
+          {
+            'active_key' => 'false',
+            'inactive_key' => 'true'
+          }
+        }
+
+        before do
+          described_class.instance.mass_toggle!(keys)
+          allow(subject).to receive(:features).and_return(['active_key', 'inactive_key'])
+        end
+
+        it do
+          expect(subject.available_features(memoize: true)).to eq({ 'active_key' => 'true', 'inactive_key' => 'false' })
+          described_class.instance.mass_toggle!(updated_keys)
+          expect(subject.available_features(memoize: true)).to eq({ 'active_key' => 'true', 'inactive_key' => 'false' })
+        end
+      end
     end
 
     describe '#mass_toggle!' do