Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add proguard rules #489

Merged
merged 1 commit into from
Jun 19, 2023
Merged

add proguard rules #489

merged 1 commit into from
Jun 19, 2023

Conversation

ebsangam
Copy link
Contributor

Solves issue on Android where user needs to add proguard rules. This PR will add proguard rules to the plugin.

Copy link
Contributor

@IVLIVS-III IVLIVS-III left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did I understand correctly, that after merging this PR users of the device_calendar plugin no longer need to add that line to their proguard file anymore?

What happens if a user uses other rules in their proguard file, will they be merged by proguard?

If so, please also change the Readme, that it no longer says users must add that line to their proguard files.

example/android/build.gradle Show resolved Hide resolved
@ebsangam
Copy link
Contributor Author

ebsangam commented Jun 19, 2023

Did I understand correctly, that after merging this PR users of the device_calendar plugin no longer need to add that line to their proguard file anymore?

What happens if a user uses other rules in their proguard file, will they be merged by proguard?

If so, please also change the Readme, that it no longer says users must add that line to their proguard files.

  1. App will no longer needs to add proguard rules.
  2. They will be merged.
  3. Updated.

Copy link
Contributor

@IVLIVS-III IVLIVS-III left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@IVLIVS-III IVLIVS-III merged commit 3c24520 into builttoroam:develop Jun 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants