Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iOs fix - allDay event does not span multiple days #413

Conversation

vasilich6107
Copy link

@vasilich6107 vasilich6107 commented Feb 20, 2022

Fix for #220

@vasilich6107
Copy link
Author

vasilich6107 commented Feb 20, 2022

@thomassth
Copy link
Contributor

Your fix looked a bit ... simple?

Does it set the multiple all-day events in iOS correctly?

And if that's the case, we need to update the demo app as well

@vasilich6107
Copy link
Author

Hi @thomassth
In understand your concerns about the fix)

I will film a short video for you later today.

@thomassth
Copy link
Contributor

A simple Y/N would do 😂

And we need to write a test for it too

@vasilich6107
Copy link
Author

Got you)

Yes it fixes the issue and creates multiday allday event.

I will add the tests and ping you.

@thomassth thomassth added help wanted This issue is open for someone to pick up and action good first issue Good for newcomers labels Mar 27, 2022
@thomassth
Copy link
Contributor

You need to rebase your PR before merging.

@thomassth thomassth linked an issue Oct 7, 2022 that may be closed by this pull request
@vasilich6107
Copy link
Author

Ok, will do

@vasilich6107 vasilich6107 force-pushed the bugfix/ios-allDay_event_does_not_span_multiple_days branch from 1daf996 to c3a4124 Compare October 11, 2022 17:18
@OleksandraFedotova
Copy link

That is not enough for the fix, you do not take into account the timezone set - in your fix - all FullDay events for multiple days and not - will have midnight time - I checked that on the test IOS device
Check my PR - there is a correct fix for that - #450

@vasilich6107 vasilich6107 deleted the bugfix/ios-allDay_event_does_not_span_multiple_days branch October 13, 2022 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted This issue is open for someone to pick up and action tests & examples
Projects
None yet
Development

Successfully merging this pull request may close these issues.

allDay event does not span multiple days
4 participants