-
Notifications
You must be signed in to change notification settings - Fork 267
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
iOs fix - allDay event does not span multiple days #413
iOs fix - allDay event does not span multiple days #413
Conversation
Hi @bhl09 Could you look at my PR |
Your fix looked a bit ... simple? Does it set the multiple all-day events in iOS correctly? And if that's the case, we need to update the demo app as well |
Hi @thomassth I will film a short video for you later today. |
A simple Y/N would do 😂 And we need to write a test for it too |
Got you) Yes it fixes the issue and creates multiday allday event. I will add the tests and ping you. |
You need to rebase your PR before merging. |
Ok, will do |
1daf996
to
c3a4124
Compare
That is not enough for the fix, you do not take into account the timezone set - in your fix - all FullDay events for multiple days and not - will have midnight time - I checked that on the test IOS device |
Fix for #220