Implementing Rrule package #403

GoldenSoju · 2022-01-05T13:00:09Z

New Pull Request for #400, related to #298

Currently working in example:

can build daily or weekly recurring events.
can build monthly or yearly events.
can build complex (eg. multi days a week) events.
can delete all events in the chain.
can delete single events.
can delete this and following instances

Hurdles (all should be solved before merge):

rrule changes are published.
most features are working / non-working features hidden and labeled.
re-enable lower API support (full or partial), or document why they should be dropped.

…on19/event-constructor-params)

…tmckenzie/fixes

GoldenSoju · 2022-01-06T06:06:57Z

Sorry all this merging and conflict solving had me a bit confused...
I added two more commits as it seems that it wasn't pushed correctly yesterday.

thomassth · 2022-01-06T08:56:21Z

@GoldenSoju I can only get some of the features working right now. Is this intended?

GoldenSoju · 2022-01-06T09:15:41Z

@thomassth no, not at all intended.
My working version branch works fine...
Let me try to compare my working branch and this branch to see what went missing during the merge.

thomassth · 2022-01-06T09:22:26Z

I've added a checklist to the top.

Feel free to add lines and check items that are done.

(Do you think we need a separate checklist for android and iOS?)

thomassth · 2022-01-06T09:40:40Z

I think you have pulled all of the changes bar some dependency updates.

Maybe it's the example 's problem?

GoldenSoju/device_calendar@GoldenSoju:develop_rrule...fast_merge_develop_rrule

GoldenSoju · 2022-01-06T12:24:15Z

Hm just some minor corrections were needed but now it should work fine.
I also had to correct something in my version of the Rrule package, I guess that was the main bug for the monthly and yearly recurrences to fail.
Deletion also seems to work fine.

(Do you think we need a separate checklist for android and iOS?)

No I don't think that will be necessary. After all, the iOS EKRecurrenceRule is actually just the iCalendar Rrule with a different name.
You can also get a valid Rrule String if you convert the EKRecurrenceRule to AnyObject.
(See SwiftDeviceCalendarPlugin.swift beginning with line 528).
So I think iOS uses the iCalendar mechanics under the hood and no iOS specific 'magic'.

thomassth · 2022-01-06T13:38:37Z

Some bugs in current build:

Weekdays/weekends seems fixed

“first Monday of Jan, yearly” also includes all Mondays of current January, similar things on monthly (every month becomes every week)

“Every 2 years” not working

I think I’m going to write some tests.

GoldenSoju · 2022-01-07T06:26:45Z

Hm it works on my side (testing mainly with google calendar).
Can you please try again after flutter clean and flutter pub get ? Maybe you don't have the newest version of the Rrule dependency.

Also in the example app, file calendar_events.dart you might want to change line 135 to something with a bigger end date.
Sth like final endDate = DateTime.now().add(Duration(days: 365 * 4));.
Atm it only catches events from -/+ 30 days.

thomassth · 2022-01-07T07:00:43Z

I'll try later today.

Either way your rrule package need to be merged to the main branch first.

If you think it's ready go submit a PR.

GoldenSoju · 2022-01-07T14:33:25Z

I just submitted the pull request for the rrule package.

… Android part;

GoldenSoju · 2022-01-20T08:36:18Z

@thomassth
The Rrule package supports now JSON(iCAL format) and I applied the changes to the Flutter and Android part.
I will start working on the iOS part today/tomorrow.
If you want to check, I commited the newest changes to this branch

GoldenSoju · 2022-01-23T09:07:11Z

@thomassth
iOS implementation is also finished.
I tested daily/weekly/monthly and yearly recurrences and it seems all to work and the resulting recurrence rule strings also are all correct as far as I've seen. Therefore I think Android/iOS parts are fine, while minor errors might occur due to the example app (add event page).

… fast_merge_develop_rrule � Conflicts: � android/src/main/kotlin/com/builttoroam/devicecalendar/CalendarDelegate.kt � android/src/main/kotlin/com/builttoroam/devicecalendar/DeviceCalendarPlugin.kt � example/lib/presentation/pages/calendar_event.dart � ios/Classes/SwiftDeviceCalendarPlugin.swift � lib/src/device_calendar.dart

… clean up.

…ast_merge_develop_rrule # Conflicts: # ios/Classes/SwiftDeviceCalendarPlugin.swift

GoldenSoju · 2022-01-26T11:39:49Z

@thomassth
Ok I also merged all outstanding commits from the main branch into this one. So it is up to date.
I got everything working so far, except All Day events in the example app. Haven't figured out yet how to solve the problem though.

Reworking example to work correctly with new recurrence rule; Several bug fixes;

Fixing example to work correctly with recurring multi-(all-)day events; adding addPostFrameCallback to even_item.dart to avoid state error;

GoldenSoju · 2022-06-28T06:19:20Z

@thomassth
Hi!
I implemented the device_calendar package with rrule package in one of my projects and found some shortcomings in the previous pull requests.

The newest version fixes those problems and the example is also now working correctly (there are no specified tests yet, but so far manual testing works fine on Android and iOS).

The only functionality still missing at the moment would be multi-all-day-events (with or without recurrence) on iOS, but I saw there was another pull request/discussion for that problem.

Please check the newest version if you have time.

…of event (android only)

thomassth · 2022-10-01T20:28:45Z

After rebase, I can confirm all these are working with rrule on android. But they need to be tested on iOS:
(use the delete button within the details page)

can build daily or weekly recurring events.
can build monthly or yearly events.
can build complex (eg. multi days a week) events.
can delete all events in the chain.
can delete single events.
can delete this and following instances

Also needs to check if it overwrites other PRs, since this is quite beefy
Especially #410

GoldenSoju · 2022-10-05T10:56:55Z

@thomassth

I checked on iOS, below all points work without problems.

can build daily or weekly recurring events.
can build monthly or yearly events.
can build complex (eg. multi days a week) events.
can delete all events in the chain.
can delete single events.
can delete this and following instances

Also all tests were passed on iOS.

Also needs to check if it overwrites other PRs, since this is quite beefy
Especially #410

Seems like your latest commits reflect all changes made in develop branch of builttoroam/device_calendar. All seems to be up-to-date according to comparison.

thomassth · 2022-10-05T16:12:32Z

Great!

One last thing, @GoldenSoju are you participating in Hacktoberfest? I can add the tag in

GoldenSoju · 2022-10-06T02:46:48Z

@thomassth

Great!

One last thing, @GoldenSoju are you participating in Hacktoberfest? I can add the tag in

Thanks for asking, that would be nice! :)

GoldenSoju and others added 6 commits August 6, 2021 15:43

update to event model (Merge pull request builttoroam#319 from CJohns…

2d3a345

…on19/event-constructor-params)

1) Correct deprecations, 2) Change print to debugPrint globally.

e3f58d0

1) Upgrade to Embed V2; 2) Merge pull request builttoroam#311 from rm…

2c6708d

…tmckenzie/fixes

Initial commit for working version with Rrule;

cedb832

iOS functioning version

72d0571

Solved conflicts in Merging myfork/develop_rrule -> builttoroam/develop

da6453f

GoldenSoju mentioned this pull request Jan 5, 2022

Pull request related to [Issue 298 - Change of actual Recurrence Rule Class] #400

Closed

This comment has been minimized.

Sign in to view

GoldenSoju added 2 commits January 6, 2022 14:57

Changes after solving merge conflicts

13daa4b

Hotfix: Add correct Rrule package fork to pubspec

759487a

thomassth mentioned this pull request Jan 6, 2022

Implementiing Rrule package (cherrypick test) #404

Closed

6 tasks

thomassth changed the title ~~Fast merge develop rrule~~ Implementiing Rrule package Jan 6, 2022

thomassth changed the title ~~Implementiing Rrule package~~ Implementing Rrule package Jan 6, 2022

thomassth marked this pull request as draft January 6, 2022 08:57

Clean up and minor corrections;

e5d8c42

Implement newest version of the official RRULE package on Flutter and…

fe43c10

… Android part;

Implement newest version of the official RRULE package on iOS;

47dc314

GoldenSoju added 2 commits January 26, 2022 18:47

Code base update with 'builttoroam/device_calendar'(develop) and code…

2e28d00

… clean up.

Merge remote-tracking branch 'MyFork/fast_merge_develop_rrule' into f…

c968278

…ast_merge_develop_rrule # Conflicts: # ios/Classes/SwiftDeviceCalendarPlugin.swift

thomassth added help wanted This issue is open for someone to pick up and action good first issue Good for newcomers enhancement New feature or request labels Mar 27, 2022

thomassth marked this pull request as ready for review March 27, 2022 14:38

GoldenSoju added 3 commits April 14, 2022 15:10

Update/Sync of Event class (event.dart).

26a9000

Update/Sync of Event class from main branch (adding event status);

0e64a98

Reworking example to work correctly with new recurrence rule; Several bug fixes;

Enabling recurring multi-(all-)day events;

a05e980

Fixing example to work correctly with recurring multi-(all-)day events; adding addPostFrameCallback to even_item.dart to avoid state error;

Bugfix for null pointer error of event status when deleting instance …

11cb931

…of event (android only)

thomassth mentioned this pull request Oct 4, 2022

updated recurrence frequency #442

Closed

thomassth added 4 commits October 5, 2022 00:51

Merge commit '11cb931e6596a402b955924acdc853fc0c6beb26' into develop

1003c67

Merge commit '1003c67dcd2b83f28c7971b5f1fbd397c3497f72' into develop

2f49382

package ver sync

7dbb155

swift eventstatus fix

4378be0

thomassth force-pushed the fast_merge_develop_rrule branch from 8729ec3 to 4378be0 Compare October 5, 2022 05:37

Revert of merge 6029acf and commit 8cd7d14

3e8662b

GoldenSoju force-pushed the fast_merge_develop_rrule branch from 8cd7d14 to 3e8662b Compare October 5, 2022 10:07

thomassth approved these changes Oct 5, 2022

View reviewed changes

thomassth added the hacktoberfest-accepted reward for PRs label Oct 6, 2022

thomassth merged commit 40b1135 into builttoroam:develop Oct 6, 2022

This was referenced Oct 7, 2022

Edit individual instances of recurring event #107

Closed

Fixed bug where DAILY freq gave a compile error #432

Closed

[5.0] rrule compatability #446

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Implementing Rrule package #403

Implementing Rrule package #403

GoldenSoju commented Jan 5, 2022 •

edited

Loading

This comment has been minimized.

GoldenSoju commented Jan 6, 2022

thomassth commented Jan 6, 2022

GoldenSoju commented Jan 6, 2022 •

edited

Loading

thomassth commented Jan 6, 2022

thomassth commented Jan 6, 2022

GoldenSoju commented Jan 6, 2022 •

edited

Loading

thomassth commented Jan 6, 2022

GoldenSoju commented Jan 7, 2022

thomassth commented Jan 7, 2022

GoldenSoju commented Jan 7, 2022

GoldenSoju commented Jan 20, 2022

GoldenSoju commented Jan 23, 2022

GoldenSoju commented Jan 26, 2022

GoldenSoju commented Jun 28, 2022

thomassth commented Oct 1, 2022 •

edited

Loading

GoldenSoju commented Oct 5, 2022 •

edited

Loading

thomassth commented Oct 5, 2022

GoldenSoju commented Oct 6, 2022

Implementing Rrule package #403

Implementing Rrule package #403

Conversation

GoldenSoju commented Jan 5, 2022 • edited Loading

This comment has been minimized.

GoldenSoju commented Jan 6, 2022

thomassth commented Jan 6, 2022

GoldenSoju commented Jan 6, 2022 • edited Loading

thomassth commented Jan 6, 2022

thomassth commented Jan 6, 2022

GoldenSoju commented Jan 6, 2022 • edited Loading

thomassth commented Jan 6, 2022

GoldenSoju commented Jan 7, 2022

thomassth commented Jan 7, 2022

GoldenSoju commented Jan 7, 2022

GoldenSoju commented Jan 20, 2022

GoldenSoju commented Jan 23, 2022

GoldenSoju commented Jan 26, 2022

GoldenSoju commented Jun 28, 2022

thomassth commented Oct 1, 2022 • edited Loading

GoldenSoju commented Oct 5, 2022 • edited Loading

thomassth commented Oct 5, 2022

GoldenSoju commented Oct 6, 2022

GoldenSoju commented Jan 5, 2022 •

edited

Loading

GoldenSoju commented Jan 6, 2022 •

edited

Loading

GoldenSoju commented Jan 6, 2022 •

edited

Loading

thomassth commented Oct 1, 2022 •

edited

Loading

GoldenSoju commented Oct 5, 2022 •

edited

Loading