-
Notifications
You must be signed in to change notification settings - Fork 267
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implementing Rrule package #403
Implementing Rrule package #403
Conversation
…on19/event-constructor-params)
…tmckenzie/fixes
This comment has been minimized.
This comment has been minimized.
Sorry all this merging and conflict solving had me a bit confused... |
@GoldenSoju I can only get some of the features working right now. Is this intended? |
@thomassth no, not at all intended. |
I've added a checklist to the top. Feel free to add lines and check items that are done. (Do you think we need a separate checklist for android and iOS?) |
I think you have pulled all of the changes bar some dependency updates. Maybe it's the GoldenSoju/device_calendar@GoldenSoju:develop_rrule...fast_merge_develop_rrule |
Hm just some minor corrections were needed but now it should work fine.
No I don't think that will be necessary. After all, the iOS EKRecurrenceRule is actually just the iCalendar Rrule with a different name. |
Some bugs in current build: Weekdays/weekends seems fixed “first Monday of Jan, yearly” also includes all Mondays of current January, similar things on monthly (every month becomes every week) “Every 2 years” not working I think I’m going to write some tests. |
Hm it works on my side (testing mainly with google calendar). Also in the example app, file |
I'll try later today. Either way your rrule package need to be merged to the main branch first. If you think it's ready go submit a PR. |
I just submitted the pull request for the rrule package. |
@thomassth |
@thomassth |
… fast_merge_develop_rrule � Conflicts: � android/src/main/kotlin/com/builttoroam/devicecalendar/CalendarDelegate.kt � android/src/main/kotlin/com/builttoroam/devicecalendar/DeviceCalendarPlugin.kt � example/lib/presentation/pages/calendar_event.dart � ios/Classes/SwiftDeviceCalendarPlugin.swift � lib/src/device_calendar.dart
…ast_merge_develop_rrule # Conflicts: # ios/Classes/SwiftDeviceCalendarPlugin.swift
@thomassth |
Reworking example to work correctly with new recurrence rule; Several bug fixes;
Fixing example to work correctly with recurring multi-(all-)day events; adding addPostFrameCallback to even_item.dart to avoid state error;
@thomassth The newest version fixes those problems and the example is also now working correctly (there are no specified tests yet, but so far manual testing works fine on Android and iOS). The only functionality still missing at the moment would be multi-all-day-events (with or without recurrence) on iOS, but I saw there was another pull request/discussion for that problem. Please check the newest version if you have time. |
…of event (android only)
After rebase, I can confirm all these are working with
Also needs to check if it overwrites other PRs, since this is quite beefy |
8729ec3
to
4378be0
Compare
8cd7d14
to
3e8662b
Compare
I checked on iOS, below all points work without problems.
Also all tests were passed on iOS.
Seems like your latest commits reflect all changes made in develop branch of builttoroam/device_calendar. All seems to be up-to-date according to comparison. |
Great! One last thing, @GoldenSoju are you participating in Hacktoberfest? I can add the tag in |
Thanks for asking, that would be nice! :) |
New Pull Request for #400, related to #298
Currently working in
example
:Hurdles (all should be solved before merge):
rrule
changes are published.