Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integration test #380

Merged
merged 2 commits into from
Dec 18, 2021
Merged

Integration test #380

merged 2 commits into from
Dec 18, 2021

Conversation

thomassth
Copy link
Contributor

@thomassth thomassth commented Dec 17, 2021 •
edited
Loading

  • Integration tests upgraded to latest model, and totally working!
  • Depreciated items in example updated

Needed for latest flutter versions

sowens-csd
sowens-csd reviewed Dec 17, 2021
View reviewed changes
Copy link
Contributor

@sowens-csd sowens-csd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see quite a few pumpAndSettle calls, those were not recommended the last time I looked. Did you find the tests didn't work without that?

@thomassth
Copy link
Contributor Author

thomassth commented Dec 17, 2021 •
edited
Loading

They seemed to be used all over the place in the new framework
https://docs.flutter.dev/cookbook/testing/integration/introduction#4-write-the-integration-test

overall I’m looking at how to future proof this plugin, like how the depreciated parts are now unsupported outright.

@thomassth thomassth merged commit 00f1f3b into builttoroam:develop Dec 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sowens-csd sowens-csd sowens-csd approved these changes

@nickrandolph nickrandolph Awaiting requested review from nickrandolph

@andzejsw andzejsw Awaiting requested review from andzejsw

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thomassth @sowens-csd