Emergency fix: not getting times from events #377
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I can test, can you let me know how you tested on Android? |
|
Does the sample app show the problem? |
|
Retrieve events from a calendar should reproduce this issue. The event
should have proper start and end time according to the event in calendar. I
found this issue on Android. Didn't check on Apple.
…On Fri, 3 Dec, 2021, 9:21 pm Stephen Owens, ***@***.***> wrote:
Does the sample app show the problem?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#377 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AANZ4TBAB6CDX2GPEQCAENTUPDRPHANCNFSM5JJ5PDIA>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
|
|
This patch fixed the issue on Android. Xcode needs way too much disk space, I'm still cleaning up for room to install. If you’re brave we can push to prerelease first? |
thomassth
added
bug
sowens-csd
approved these changes
Dec 3, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discovered in #374 by @nitinjavakid
Continuing #316 and originated from #297, we haven’t renamed all labels when migrating all the variables.
I’ve tested on Android but cannot get an iOS device to test yet. Can someone help test it?