New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cached results in Request Permission has eventId and calendarId in wrong order for delete/ #258

Closed

rmtmckenzie opened this issue Sep 4, 2020 · 0 comments

Contributor

rmtmckenzie commented Sep 4, 2020 •

edited

Loading

device_calendar/android/src/main/kotlin/com/builttoroam/devicecalendar/CalendarDelegate.kt

Line 139 in b14d1fd

    
           deleteEvent(cachedValues.eventId, cachedValues.calendarId, cachedValues.pendingChannelResult)

Whereas deleteEvent is declared as:

fun deleteEvent(calendarId: String, eventId: String, pendingChannelResult: MethodChannel.Result, startDate: Long? = null, endDate: Long? = null, followingInstances: Boolean? = null) {

Order of eventId and calendarId should be reversed.

nickrandolph pushed a commit that referenced this issue


          Fix issue #258

6efef84

andzejsw closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment