Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: set lazy mode to true when setting shannon e2e test config #99

Merged
merged 3 commits into from
Dec 13, 2024

Conversation

commoddity
Copy link
Contributor

This is to minimize the confusing log entries if an E2E test fails.

Discord conversation:
https://discord.com/channels/824324475256438814/1316586048670666802/1316744288910184560

@commoddity commoddity added the CI Anything related to Github Actions/CI label Dec 12, 2024
@commoddity commoddity added this to the Path MVP milestone Dec 12, 2024
@commoddity commoddity requested a review from adshmh December 12, 2024 12:39
@commoddity commoddity self-assigned this Dec 12, 2024
Copy link
Contributor

@Olshansk Olshansk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@commoddity One comment but otherwise LGTM.

e2e/scripts/update_shannon_config_from_secrets.sh Outdated Show resolved Hide resolved
@commoddity commoddity merged commit a218a9a into main Dec 13, 2024
1 check passed
@commoddity commoddity deleted the set-lazy-mode-in-test-config branch December 13, 2024 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Anything related to Github Actions/CI
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

2 participants