feat: DB driver and cache #15

commoddity · 2024-09-09T11:05:13Z

Related to #11

PR to add a Postgres database driver using SQLC to generate Go code from SQL files:
https://sqlc.dev/

This is the first prerequisite to allow associating a service request with a user for the purposes of metering, billing, rate limiting, user settings, etc.

This PR adds the following:

db/driver package containing Postgres driver
db package containing local cache of user data
user package containing the GatewayEndpoint struct

Signed-off-by: Pascal van Leeuwen <[email protected]>

Olshansk

@commoddity Great start!

I did a high-level preliminary review (see screenshot below) but just wanted to pause it here because I have some questions w.r.t to the naming decisions.

Lmk if it makes sense or if we need to sync over a call.

README.md

db/driver/sqlc/query.sql

db/driver/sqlc/schema.sql

README.md

Co-authored-by: Daniel Olshansky <[email protected]> Signed-off-by: Pascal van Leeuwen <[email protected]>

Olshansk

@commoddity REALLY love how this is shaping up. I think we're almost there and this should be my last round of a lot of comments.

We're close and ty for bearing with the iterations 🙏

user/gateway_endpoint.go

README.md

config/config_test.go

config/user_data.go

db/cache.go

README.md

docker/docker-compose.full.yml

docker/docker-compose.yml

Co-authored-by: Daniel Olshansky <[email protected]> Signed-off-by: Pascal van Leeuwen <[email protected]>

commoddity · 2024-09-13T07:22:30Z

@Olshansk Have addressed or responded to all review comments. PTAL. We're almost there. 🙂

Olshansk

Not a review - just publishing my comments on previous threads and will dive into a full review shortly.

Makefile

db/postgres/sqlc/schema.sql

docker/docker-compose.yml

config/user_data.go

config/config_test.go

config/utils/utils.go

db/driver_mock_test.go

docker/docker-compose.yml

router/router_test.go

db/postgres/testdata/seed-test-db.sql

db/postgres/sqlc/schema.sql

docker/docker-compose.full.yml

db/postgres/sqlc/query.sql

db/postgres/driver.go

Olshansk · 2024-09-16T21:04:12Z

@adshmh Would appreciate if you could review this as well.

router/router.go

router/router_test.go

Makefile

db/cache_test.go

cmd/main.go

Signed-off-by: commoddity <[email protected]>

Olshansk

LGTM! Let's just get a 👍 from @adshmh as well before merging it in

adshmh

Pre-approving with one ask:

Please add TODOs to address the following:

Our overall Authentication solution.
Alternatives to DBs as source of truth: e.g. config files, API servers, etc.

commoddity added 8 commits September 7, 2024 10:00

feat: adds postgres driver and cache for user apps

9712372

chore: add cache_refresh_interval to example yaml

6519d94

fix: use whitelist type and value string types

297aa4c

fix: update to use allowlists with enum

76484a6

fix: update throughput to rate limit and add capacity

7b42346

fix: remove capacity limit field for now

c9e0955

fix: unit tests

41f5f08

chore: update README.md

2043664

commoddity added the enhancement New feature or request label Sep 9, 2024

commoddity self-assigned this Sep 9, 2024

commoddity requested review from adshmh and Olshansk September 9, 2024 11:05

commoddity linked an issue Sep 9, 2024 that may be closed by this pull request

[Umbrella Ticket] PATH User Database #11

Open

10 tasks

commoddity mentioned this pull request Sep 9, 2024

[MERGE AFTER #15] feat: update router and gateway for user data handling. #16

Closed

commoddity added 2 commits September 9, 2024 12:12

fix: failing e2e test validate

1b821e5

fix: failing e2e test hydrate

2e2195a

commoddity mentioned this pull request Sep 9, 2024

[Umbrella Ticket] PATH User Database #11

Open

10 tasks

commoddity marked this pull request as ready for review September 9, 2024 19:24

Merge branch 'main' into db-driver-and-cache

9acc6b1

Signed-off-by: Pascal van Leeuwen <[email protected]>

commoddity removed a link to an issue Sep 9, 2024

[Umbrella Ticket] PATH User Database #11

Open

10 tasks

Olshansk added this to the Path MVP milestone Sep 9, 2024

Olshansk requested changes Sep 9, 2024

View reviewed changes

commoddity and others added 7 commits September 10, 2024 08:25

Apply suggestions from code review

99c31a7

Co-authored-by: Daniel Olshansky <[email protected]> Signed-off-by: Pascal van Leeuwen <[email protected]>

fix: godoc comments in user app

26bd10d

chore: plan type in driver.go

a0f9af2

fix: enforce db driver interface

8ba5d98

fix: unit test for cache

aa968ef

fix: replace mockery with mockgen and create own mock file

b5e6dd4

fix: improve comments for clarity

581a18b

commoddity force-pushed the db-driver-and-cache branch from ac0cfdd to 581a18b Compare September 10, 2024 09:08

commoddity added 2 commits September 12, 2024 10:34

fix: package name in db/postrges

0aa4d28

fix: move docker compose to own folder

8051622

Olshansk requested changes Sep 13, 2024

View reviewed changes

commoddity and others added 3 commits September 13, 2024 08:17

fix: address review comments

27bd8a2

Apply suggestions from code review

b4cd412

Co-authored-by: Daniel Olshansky <[email protected]> Signed-off-by: Pascal van Leeuwen <[email protected]>

chore: merge conflicts

63ff67b

commoddity requested a review from Olshansk September 13, 2024 07:23

Olshansk requested changes Sep 16, 2024

View reviewed changes

Makefile Show resolved Hide resolved

db/postgres/sqlc/schema.sql Outdated Show resolved Hide resolved

docker/docker-compose.yml Outdated Show resolved Hide resolved

config/user_data.go Outdated Show resolved Hide resolved

commoddity requested a review from Olshansk September 16, 2024 18:23

Olshansk requested changes Sep 16, 2024

View reviewed changes

commoddity added 4 commits September 17, 2024 15:51

chore: move docker-compose.yml and add make targets

95a6e7f

fix: update router test with mockgen and params

ff54f48

chore: implement review suggestions

d04e9a5

fix: remove user data from config

b903984

commoddity requested a review from Olshansk September 17, 2024 19:27

Olshansk requested changes Sep 17, 2024

View reviewed changes

commoddity added 3 commits September 18, 2024 11:27

chore: merge conflicts

84ac602

chore: move helper func to postgres package

38a7c95

fix: address review comments

1bacf35

commoddity requested a review from Olshansk September 18, 2024 10:36

Merge branch 'main' into db-driver-and-cache

d5618cf

Signed-off-by: commoddity <[email protected]>

Olshansk approved these changes Sep 18, 2024

View reviewed changes

adshmh approved these changes Sep 19, 2024

View reviewed changes

commoddity added 3 commits September 19, 2024 19:08

chore: merge conflicts

e64ad5a

chore: envoy folder structure

6ebe8e0

fix: correct docker version in dockerfile

edfc376

commoddity merged commit bd4e0cf into main Sep 19, 2024
4 checks passed

commoddity deleted the db-driver-and-cache branch September 19, 2024 18:19

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: DB driver and cache #15

feat: DB driver and cache #15

commoddity commented Sep 9, 2024 •

edited

Loading

Olshansk left a comment

Olshansk left a comment

commoddity commented Sep 13, 2024 •

edited

Loading

Olshansk left a comment

Olshansk commented Sep 16, 2024

Olshansk left a comment

adshmh left a comment

feat: DB driver and cache #15

feat: DB driver and cache #15

Conversation

commoddity commented Sep 9, 2024 • edited Loading

Olshansk left a comment

Choose a reason for hiding this comment

Olshansk left a comment

Choose a reason for hiding this comment

commoddity commented Sep 13, 2024 • edited Loading

Olshansk left a comment

Choose a reason for hiding this comment

Olshansk commented Sep 16, 2024

Olshansk left a comment

Choose a reason for hiding this comment

adshmh left a comment

Choose a reason for hiding this comment

commoddity commented Sep 9, 2024 •

edited

Loading

commoddity commented Sep 13, 2024 •

edited

Loading