-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Docs] Refactoring the PATH
Developer Guide docs
#137
Conversation
PATH
Developer Guide docs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@adshmh @commoddity PTAL a detail look.
Need a close set of 👀 and 👐 on this one as I touched/refactored a lot of this on the developer experience front.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great PR. Loving the way the docs are taking shape here; the splitting apart of some of the bigger pages into different sections makes a world of difference in reducing the mental overload. Ditto for the Makefiles.
Just a few comments and notes but definitely like what this is doing to the docs.
Co-authored-by: commoddity <[email protected]>
Co-authored-by: commoddity <[email protected]>
Co-authored-by: commoddity <[email protected]>
Co-authored-by: commoddity <[email protected]>
@commoddity I'm still testing + updating the PR but most of the comments you left should be addressed here: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@commoddity PTAL again when you can!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for the changes.
Summary
Restructure config management and documentation for better organization and clarity
Primary Changes:
morse_configs.mk
,shannon_configs.mk
)lazy_mode=true
by default in Shannon protocol because it lost support in [Protocol] Correct the scope of onchain app queries made by Shannon protocol instance #140Secondary changes:
./bin/config/.config.yaml
and bias to./local/path/config/.config.yaml
everywhereType of change
Select one or more from the following:
Testing
make test_all
make docusaurus_start
; only needed if you make doc changesSanity Checklist