fix: update the jsonrpc.Response struct to adhere to the JSONRPC spec #130
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the
jsonrpc.Response
struct used forqos
to adhere to the JSON-RPC spec, as well as update its.Validate
method.Issue
There were some small discrepancies between the official JSON-RPC spec and our
jsonrpc.Response
struct.Specifically the
error
object was always being included even without an actual error, which is prohibited by the JSON-RPC spec.As well the presence of either neither or both of
result
anderror
was not being validated.Source: https://www.jsonrpc.org/specification#response_object
Type of change
Select one or more from the following:
Testing
make test_all
make docusaurus_start
; only needed if you make doc changesSanity Checklist