Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Platform api changes to support phase 1 of Dockerfiles implementation #308

Merged
merged 14 commits into from
Aug 23, 2022
Merged

Platform api changes to support phase 1 of Dockerfiles implementation #308

merged 14 commits into from
Aug 23, 2022

Conversation

natalieparellano
Copy link
Member

@natalieparellano natalieparellano commented Apr 15, 2022 •
edited
Loading

Accompanies #307

@natalieparellano natalieparellano requested a review from a team as a code owner April 15, 2022 20:17
natalieparellano
natalieparellano commented Apr 15, 2022
View reviewed changes
platform.md Outdated Show resolved Hide resolved
This was referenced Apr 18, 2022
Closed
Closed
natalieparellano
natalieparellano commented Apr 19, 2022
View reviewed changes
platform.md Outdated Show resolved Hide resolved
natalieparellano
natalieparellano commented Apr 19, 2022
View reviewed changes
platform.md Outdated Show resolved Hide resolved
natalieparellano
natalieparellano commented Apr 19, 2022
View reviewed changes
platform.md Outdated Show resolved Hide resolved
natalieparellano
natalieparellano commented Apr 19, 2022
View reviewed changes
platform.md Outdated Show resolved Hide resolved
@natalieparellano natalieparellano mentioned this pull request Apr 27, 2022
Merged
natalieparellano
natalieparellano commented May 2, 2022
View reviewed changes
platform.md Outdated Show resolved Hide resolved
@natalieparellano
Add extensions to build metadata
e669a53 
Signed-off-by: Natalie Arellano <[email protected]>
@hone hone requested a review from jromero May 4, 2022 18:13
@natalieparellano natalieparellano mentioned this pull request May 17, 2022
Closed
natalieparellano
natalieparellano commented Jun 7, 2022
View reviewed changes
platform.md Outdated Show resolved Hide resolved
natalieparellano
natalieparellano commented Jun 15, 2022
View reviewed changes
platform.md Outdated Show resolved Hide resolved
natalieparellano
natalieparellano commented Jun 15, 2022
View reviewed changes
platform.md Outdated Show resolved Hide resolved
jromero
jromero reviewed Jun 15, 2022
View reviewed changes
platform.md Outdated Show resolved Hide resolved
jromero
jromero reviewed Jun 15, 2022
View reviewed changes
platform.md Outdated Show resolved Hide resolved
@jromero
Copy link
Member

jromero commented Jun 15, 2022

@natalieparellano could we label what flags and executables will be gated behind an experimental flag?

@natalieparellano
Copy link
Member Author

Thanks for the review @jromero. I need to update this PR a bit with the learnings from the implementation (1, 2). I'll write back when that's completed.

@natalieparellano
Updates from implementation
9867543 
Signed-off-by: Natalie Arellano <[email protected]>
@natalieparellano natalieparellano requested a review from a team as a code owner June 15, 2022 21:14
@natalieparellano
Add extension to build plan
da18b78 
Signed-off-by: Natalie Arellano <[email protected]>
natalieparellano
natalieparellano commented Jun 16, 2022
View reviewed changes
platform.md Outdated Show resolved Hide resolved
@natalieparellano natalieparellano self-assigned this Jun 16, 2022
natalieparellano
natalieparellano commented Jun 22, 2022
View reviewed changes
platform.md Outdated Show resolved Hide resolved
natalieparellano
natalieparellano commented Jun 22, 2022
View reviewed changes
platform.md Outdated Show resolved Hide resolved
@natalieparellano natalieparellano mentioned this pull request Jun 23, 2022
Open
42 tasks
@jromero jromero self-requested a review June 24, 2022 19:42
@natalieparellano natalieparellano added this to the Platform 0.10 milestone Jun 29, 2022
@natalieparellano
Fix generate exit code
251c7a0 
The 80 range is for the launcher.

Signed-off-by: Natalie Arellano <[email protected]>
@natalieparellano
Update env var name
b900760 
Signed-off-by: Natalie Arellano <[email protected]>
jromero
jromero requested changes Jul 7, 2022
View reviewed changes
platform.md Outdated Show resolved Hide resolved
platform.md Outdated Show resolved Hide resolved
platform.md Outdated Show resolved Hide resolved
platform.md Outdated Show resolved Hide resolved
@natalieparellano
Update platform.md
642eaf4 
Co-authored-by: Javier Romero <[email protected]>

Signed-off-by: Natalie Arellano <[email protected]>
@natalieparellano
Update platform.md
e9b350a 
Co-authored-by: Javier Romero <[email protected]>

Signed-off-by: Natalie Arellano <[email protected]>
@natalieparellano
Update platform.md
be44080 
Co-authored-by: Javier Romero <[email protected]>

Signed-off-by: Natalie Arellano <[email protected]>
@natalieparellano
Clarify the meaning of extension in plan.toml
e8dda22 
Signed-off-by: Natalie Arellano <[email protected]>
@natalieparellano natalieparellano mentioned this pull request Jul 12, 2022
Merged
jromero
jromero reviewed Aug 3, 2022
View reviewed changes
platform.md Outdated Show resolved Hide resolved
@jromero jromero self-requested a review August 3, 2022 19:45
natalieparellano
natalieparellano commented Aug 16, 2022
View reviewed changes
platform.md Outdated Show resolved Hide resolved
@natalieparellano
Update platform.md
a5acc10 
Signed-off-by: Natalie Arellano <[email protected]>
jromero
jromero approved these changes Aug 16, 2022
View reviewed changes
Copy link
Member

@jromero jromero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

well-done

@natalieparellano natalieparellano merged commit b4eeb43 into main Aug 23, 2022
@natalieparellano natalieparellano deleted the extensions-platform-api branch August 23, 2022 17:11
@natalieparellano natalieparellano mentioned this pull request Aug 24, 2022
Merged
@natalieparellano natalieparellano restored the extensions-platform-api branch August 24, 2022 13:31
@natalieparellano
Copy link
Member Author

Accidentally merged into main, not platform/0.10. Will create a new PR...

@natalieparellano natalieparellano mentioned this pull request Aug 24, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sambhav sambhav sambhav approved these changes

@jromero jromero jromero approved these changes

@jkutner jkutner jkutner approved these changes

Assignees

@natalieparellano natalieparellano

Labels
None yet
Projects
None yet
Milestone
Platform 0.10
Development

Successfully merging this pull request may close these issues.
4 participants
@natalieparellano @jromero @jkutner @sambhav