Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update pipeline failure #2

Closed
sambhav opened this issue Jul 10, 2022 · 5 comments · Fixed by #3, #4 or #5
Closed

Update pipeline failure #2

sambhav opened this issue Jul 10, 2022 · 5 comments · Fixed by #3, #4 or #5
Assignees
@dmikusa

Comments

@sambhav
Copy link
Member

sambhav commented Jul 10, 2022

See https://github.com/buildpacks/profile/runs/7264000321?check_suite_focus=true

cc @dmikusa-pivotal
@dmikusa
Copy link
Contributor

dmikusa commented Jul 11, 2022 •
edited
Loading

Ah, ok. My fault. On Paketo, we usually have an env variable custom set for the user name. I plugged in GITHUB_USERNAME, not sure why in hindsight because that is not set, so it's failing this job.

There's two choices here:

  1. Set a secret with the name that you'd like to appear. This is the name and username portion of the email that is part of the CI-generated commits (like buildpacks-bot). It's only for the commit. The PR is sent as the user associated with the GITHUB_TOKEN.
  2. I think we might be able to use GITHUB_ACTOR. That says The name of the person or app that initiated the workflow. For example, octocat., which sounds reasonable.

Do you have a preference @samj1912 ?

@sambhav
Copy link
Member Author

sambhav commented Jul 12, 2022

  1. sounds better?

dmikusa pushed a commit that referenced this issue Jul 13, 2022
Switch to using GITHUB_ACTOR
ee1c12c 
Switch to using GITHUB_ACTOR as the username represented in the commit log for entries created by the pipeline.

Resolved #2

Signed-off-by: Daniel Mikusa <[email protected]>
@dmikusa dmikusa mentioned this issue Jul 13, 2022
Merged
@dmikusa
Copy link
Contributor

dmikusa commented Jul 13, 2022 •
edited
Loading

PR #3 should resolve this. I'm not sure if it can be tested prior to merging though, as we'd need to re-run the update pipeline workflow from the PR branch. I tried running from the branch, but it doesn't seem to pick up the change as it's still failing with the same issue (the username is empty, but as far as I know GITHUB_ACTOR should always be set).

sambhav pushed a commit that referenced this issue Jul 13, 2022
Switch to using GITHUB_ACTOR (#3)
a4897a2 
Switch to using GITHUB_ACTOR as the username represented in the commit log for entries created by the pipeline.

Resolved #2

Signed-off-by: Daniel Mikusa <[email protected]>
@sambhav
Copy link
Member Author

sambhav commented Jul 13, 2022

I see it still failing and I get

Failed to add secret. Secret names must not start with GITHUB_.

when I try to add it manually

@sambhav sambhav reopened this Jul 13, 2022
@sambhav
Copy link
Member Author

sambhav commented Jul 13, 2022

For some reason none of this was working so I just hard-coded the username for now

@sambhav sambhav closed this as completed Jul 13, 2022
This was linked to pull requests Jul 13, 2022
Fix pipeline variable name #4
Merged
Hardcode variable name for now #5
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dmikusa dmikusa

Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@dmikusa @sambhav