Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a helper script for testing GitHub Actions on forked repositories #2235

Merged
merged 7 commits into from
Jul 29, 2024

Conversation

hhiroshell
Copy link
Contributor

@hhiroshell hhiroshell commented Jul 24, 2024

Summary

The buildpacks/lifecycle repository has a helper script for testing GitHub Actions on forked repositories. This PR adds a script tools/test-fork.sh for the same purpose to the buildpacks/pack.

The new script makes the following changes to the existing workflows:

  • Disable the workflows that should not run on forked repositories by renaming the workflow files
  • Change the container registry account and other related information to build and push a different container image from the upstream
  • Remove build target architectures that require self-hosted runner
  • Remove upstream maintainers from the recipients of the benchmark alert

Output

N/A

Documentation

  • Should this change be documented?
    • Yes, see #___
    • No

Related

This PR is a preparation for making corrections to #2111.

Here is results of workflows tested on my fork repository.

@hhiroshell hhiroshell requested review from a team as code owners July 24, 2024 10:16
@github-actions github-actions bot added the type/chore Issue that requests non-user facing changes. label Jul 24, 2024
@github-actions github-actions bot added this to the 0.36.0 milestone Jul 24, 2024
Copy link
Member

@natalieparellano natalieparellano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome, thank you @hhiroshell!

hhiroshell and others added 2 commits July 25, 2024 18:27
Co-authored-by: Natalie Arellano <[email protected]>
Signed-off-by: Hiroshi Hayakawa <[email protected]>
Co-authored-by: Natalie Arellano <[email protected]>
Signed-off-by: Hiroshi Hayakawa <[email protected]>
@hhiroshell
Copy link
Contributor Author

@natalieparellano
Thank you for your review!

The CI task build / test (windows-lcow) (pull_request) is failing. I have no idea what changes might have caused it, but I'm currently investigating it.

@hhiroshell
Copy link
Contributor Author

It seems the task failures are random and unpredictable, and it's difficult for me to identify the cause from the CI logs alone.

Do you have any ideas about what might be causing this? Alternatively, could you please rerun the build / test (windows-lcow) (pull_request) task?

@natalieparellano
Copy link
Member

Thank you @hhiroshell. I wouldn't worry too much about these flakes. We have a number of them that we need to fix (especially on Windows). I re-kicked CI just now, let's see what happens...

@natalieparellano natalieparellano merged commit 3902749 into buildpacks:main Jul 29, 2024
16 checks passed
@hhiroshell hhiroshell deleted the fix-pack-2111-1 branch July 30, 2024 02:28
@natalieparellano natalieparellano modified the milestones: 0.36.0, 0.35.1 Jul 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/chore Issue that requests non-user facing changes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants