When parsing project.toml, don't warn about unexpected keys that are actually expected #2197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…actually expected Fixes #2192 Signed-off-by: Natalie Arellano <[email protected]>
github-actions
bot
added
the
type/enhancement
natalieparellano
commented
Jul 3, 2024
Comment on lines
+36
to
+42
| ID string `toml:"id"` | ||
| Name string `toml:"name"` | ||
| Version string `toml:"version"` | ||
| Authors []string `toml:"authors"` | ||
| DocumentationURL string `toml:"documentation-url"` | ||
| SourceURL string `toml:"source-url"` | ||
| Licenses []License `toml:"licenses"` |
There was a problem hiding this comment.
natalieparellano
commented
Jul 3, 2024
Comment on lines
+31
to
+39
| SchemaVersion string `toml:"schema-version"` | ||
| ID string `toml:"id"` | ||
| Name string `toml:"name"` | ||
| Version string `toml:"version"` | ||
| Authors []string `toml:"authors"` | ||
| Licenses []types.License `toml:"licenses"` | ||
| DocumentationURL string `toml:"documentation-url"` | ||
| SourceURL string `toml:"source-url"` | ||
| Metadata map[string]interface{} `toml:"metadata"` |
There was a problem hiding this comment.
|
@jjbustamante would you mind taking a look at this one? |
jjbustamante
approved these changes
Jul 7, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2197 +/- ##
=======================================
Coverage 70.17% 70.17%
=======================================
Files 253 253
Lines 18452 18452
=======================================
Hits 12947 12947
Misses 4659 4659
Partials 846 846
Flags with carried forward coverage won't be shown. Click here to find out more. |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2192
Summary
Output
Before
After
Documentation
Related
Resolves #___