-
Notifications
You must be signed in to change notification settings - Fork 286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Improve documentation for --publish flag #2024
Conversation
Signed-off-by: Rizul Gupta <[email protected]>
c3605d2
to
577880f
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2024 +/- ##
=======================================
Coverage 79.50% 79.50%
=======================================
Files 175 175
Lines 13114 13114
=======================================
Hits 10425 10425
Misses 2022 2022
Partials 667 667
Flags with carried forward coverage won't be shown. Click here to find out more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rizul2108 - thanks a lot for this. I left some suggestions. I avoided using making it available for deployment and use by others
because that is sort of subjective, users can have private registries with access controls and we don't want to imply that the image will automatically be made "public". LMK what you think :)
Yeah I missed that point that it can be published to private registries also.I agree about that point. |
Co-authored-by: Natalie Arellano <[email protected]> Signed-off-by: Rizul Gupta <[email protected]>
Co-authored-by: Natalie Arellano <[email protected]> Signed-off-by: Rizul Gupta <[email protected]>
Co-authored-by: Natalie Arellano <[email protected]> Signed-off-by: Rizul Gupta <[email protected]>
Co-authored-by: Natalie Arellano <[email protected]> Signed-off-by: Rizul Gupta <[email protected]>
Co-authored-by: Natalie Arellano <[email protected]> Signed-off-by: Rizul Gupta <[email protected]>
Co-authored-by: Natalie Arellano <[email protected]> Signed-off-by: Rizul Gupta <[email protected]>
Co-authored-by: Natalie Arellano <[email protected]> Signed-off-by: Rizul Gupta <[email protected]>
@natalieparellano can you please review now I committed your suggested changes |
@rizul2108 thank you so much for this contribution!! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@@ -241,7 +241,7 @@ func buildCommandFlags(cmd *cobra.Command, buildFlags *BuildFlags, cfg config.Co | |||
cmd.Flags().StringVar(&buildFlags.Network, "network", "", "Connect detect and build containers to network") | |||
cmd.Flags().StringArrayVar(&buildFlags.PreBuildpacks, "pre-buildpack", []string{}, "Buildpacks to prepend to the groups in the builder's order") | |||
cmd.Flags().StringArrayVar(&buildFlags.PostBuildpacks, "post-buildpack", []string{}, "Buildpacks to append to the groups in the builder's order") | |||
cmd.Flags().BoolVar(&buildFlags.Publish, "publish", false, "Publish to registry") | |||
cmd.Flags().BoolVar(&buildFlags.Publish, "publish", false, "Publish the application image directly to the container registry specified in <image-name>, instead of the daemon. The run image must also reside in the registry.") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do you say that the The run image must also reside in the registry
? AFAIK pack build
or pack builder
build and push image according to toml file definition and application path but I never see something about to have a run image .... @jjbustamante
Summary
I am changing the help-text for --publish flag as it was not properly descriptive earlier.
Resolves #1994