Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a new manifest command to support multi-architecture builds #1967

Closed
wants to merge 63 commits into from
Closed

Add a new manifest command to support multi-architecture builds #1967

wants to merge 63 commits into from

Commits on Nov 9, 2023

  1. WIP: added manifest_add command 

    Signed-off-by: WYGIN <[email protected]>
    @WYGIN
    WYGIN committed Nov 9, 2023
    Configuration menu
    Copy the full SHA
    17ec0e6 View commit details
    Browse the repository at this point in the history

  2. WIP added manifest_annotate command 

    Signed-off-by: WYGIN <[email protected]>
    @WYGIN
    WYGIN committed Nov 9, 2023
    Configuration menu
    Copy the full SHA
    45f39bc View commit details
    Browse the repository at this point in the history

  3. WIP added manifest_create command 

    Signed-off-by: WYGIN <[email protected]>
    @WYGIN
    WYGIN committed Nov 9, 2023
    Configuration menu
    Copy the full SHA
    5b75d95 View commit details
    Browse the repository at this point in the history

  4. WIP added manifest_exists command 

    Signed-off-by: WYGIN <[email protected]>
    @WYGIN
    WYGIN committed Nov 9, 2023
    Configuration menu
    Copy the full SHA
    9799f01 View commit details
    Browse the repository at this point in the history

  5. WIP added manifest_inspect command 

    Signed-off-by: WYGIN <[email protected]>
    @WYGIN
    WYGIN committed Nov 9, 2023
    Configuration menu
    Copy the full SHA
    1968518 View commit details
    Browse the repository at this point in the history

  6. WIP added manifest_push command 

    Signed-off-by: WYGIN <[email protected]>
    @WYGIN
    WYGIN committed Nov 9, 2023
    Configuration menu
    Copy the full SHA
    d8f6039 View commit details
    Browse the repository at this point in the history

  7. WIP added manifest_remove command 

    Signed-off-by: WYGIN <[email protected]>
    @WYGIN
    WYGIN committed Nov 9, 2023
    Configuration menu
    Copy the full SHA
    07b9150 View commit details
    Browse the repository at this point in the history

  8. WIP added manifest_rm command 

    Signed-off-by: WYGIN <[email protected]>
    @WYGIN
    WYGIN committed Nov 9, 2023
    Configuration menu
    Copy the full SHA
    a6355e1 View commit details
    Browse the repository at this point in the history

  9. WIP added add_manifest client 

    Signed-off-by: WYGIN <[email protected]>
    @WYGIN
    WYGIN committed Nov 9, 2023
    Configuration menu
    Copy the full SHA
    f24b167 View commit details
    Browse the repository at this point in the history

  10. WIP added annotate_manifest client 

    Signed-off-by: WYGIN <[email protected]>
    @WYGIN
    WYGIN committed Nov 9, 2023
    Configuration menu
    Copy the full SHA
    15ed584 View commit details
    Browse the repository at this point in the history

  11. WIP added IndexFactory to Client 

    Signed-off-by: WYGIN <[email protected]>
    @WYGIN
    WYGIN committed Nov 9, 2023
    Configuration menu
    Copy the full SHA
    8cf016e View commit details
    Browse the repository at this point in the history

  12. WIP added create_manifest client 

    Signed-off-by: WYGIN <[email protected]>
    @WYGIN
    WYGIN committed Nov 9, 2023
    Configuration menu
    Copy the full SHA
    0ed954f View commit details
    Browse the repository at this point in the history

  13. WIP added delete_manifest client 

    Signed-off-by: WYGIN <[email protected]>
    @WYGIN
    WYGIN committed Nov 9, 2023
    Configuration menu
    Copy the full SHA
    dfd4bc4 View commit details
    Browse the repository at this point in the history

  14. WIP added exists_manifest client 

    Signed-off-by: WYGIN <[email protected]>
    @WYGIN
    WYGIN committed Nov 9, 2023
    Configuration menu
    Copy the full SHA
    94ba3e3 View commit details
    Browse the repository at this point in the history

  15. WIP added inspect_manifest client 

    Signed-off-by: WYGIN <[email protected]>
    @WYGIN
    WYGIN committed Nov 9, 2023
    Configuration menu
    Copy the full SHA
    4ec02e7 View commit details
    Browse the repository at this point in the history

  16. WIP added push_manifest client 

    Signed-off-by: WYGIN <[email protected]>
    @WYGIN
    WYGIN committed Nov 9, 2023
    Configuration menu
    Copy the full SHA
    f2161a9 View commit details
    Browse the repository at this point in the history

  17. WIP added remove_manifest client 

    Signed-off-by: WYGIN <[email protected]>
    @WYGIN
    WYGIN committed Nov 9, 2023
    Configuration menu
    Copy the full SHA
    2080208 View commit details
    Browse the repository at this point in the history

  18. WIP added errors 

    Signed-off-by: WYGIN <[email protected]>
    @WYGIN
    WYGIN committed Nov 9, 2023
    Configuration menu
    Copy the full SHA
    5aa4b9f View commit details
    Browse the repository at this point in the history

  19. build(deps): bump github.com/buildpacks/lifecycle from 0.17.1 to 0.17.2 

    Bumps [github.com/buildpacks/lifecycle](https://github.com/buildpacks/lifecycle) from 0.17.1 to 0.17.2.
- [Release notes](https://github.com/buildpacks/lifecycle/releases)
- [Changelog](https://github.com/buildpacks/lifecycle/blob/main/RELEASE.md)
- [Commits](buildpacks/lifecycle@v0.17.1...v0.17.2)

---
updated-dependencies:
- dependency-name: github.com/buildpacks/lifecycle
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Signed-off-by: Juan Bustamante <[email protected]>
    @dependabot @WYGIN
    dependabot[bot] authored and WYGIN committed Nov 9, 2023
    Configuration menu
    Copy the full SHA
    d10a617 View commit details
    Browse the repository at this point in the history

  20. Updating default lifecycle version to 0.17.2 

    Signed-off-by: Juan Bustamante <[email protected]>
    @jjbustamante @WYGIN
    jjbustamante authored and WYGIN committed Nov 9, 2023
    Configuration menu
    Copy the full SHA
    32e5d1d View commit details
    Browse the repository at this point in the history

  21. Group minor/patch version Go Dependabot updates into one PR 

    Go minor/patch dependencies will now be grouped, using the new
Dependabot grouping feature:
https://github.blog/changelog/2023-08-17-grouped-version-updates-by-semantic-version-level-for-dependabot/

Major updates, as well as security updates will still be opened as
separate PRs. I've not grouped GitHub Actions update PRs, since the
volume is typically much lower for those.

In addition, the schedule has been changed from daily to weekly.

This reduces project maintenance toil (no more having to manually create
combined update PRs), plus makes it less painful for contributors to
subscribe to repository notifications (currently there is a lot of noise
from Dependabot PRs being opened/auto-rebased etc).

Signed-off-by: Ed Morley <[email protected]>
    @edmorley @WYGIN
    edmorley authored and WYGIN committed Nov 9, 2023
    Configuration menu
    Copy the full SHA
    d5d98bc View commit details
    Browse the repository at this point in the history

  22. Add buildpacksio/pack:<version>-base images to delivery 

    Signed-off-by: Natalie Arellano <[email protected]>
    @natalieparellano @WYGIN
    natalieparellano authored and WYGIN committed Nov 9, 2023
    Configuration menu
    Copy the full SHA
    bf88725 View commit details
    Browse the repository at this point in the history

  23. Add floating :base tag 

    Signed-off-by: Natalie Arellano <[email protected]>
    @natalieparellano @WYGIN
    natalieparellano authored and WYGIN committed Nov 9, 2023
    Configuration menu
    Copy the full SHA
    31654b8 View commit details
    Browse the repository at this point in the history

  24. Ensure the run image os/arch always matches: 

    - the builder for `pack build`
- the previous image for `pack rebase`

Signed-off-by: Natalie Arellano <[email protected]>
    @natalieparellano @WYGIN
    natalieparellano authored and WYGIN committed Nov 9, 2023
    Configuration menu
    Copy the full SHA
    f70fdfe View commit details
    Browse the repository at this point in the history

  25. When downloading buildpacks or extensions for pack build or `pack b… 

    …uilder create`,

ensure the os/arch matches the builder

Signed-off-by: Natalie Arellano <[email protected]>
    @natalieparellano @WYGIN
    natalieparellano authored and WYGIN committed Nov 9, 2023
    Configuration menu
    Copy the full SHA
    0133424 View commit details
    Browse the repository at this point in the history

  26. build(deps): bump the go-dependencies group with 6 updates 

    Bumps the go-dependencies group with 6 updates:

| Package | From | To |
| --- | --- | --- |
| [github.com/docker/cli](https://github.com/docker/cli) | `24.0.6+incompatible` | `24.0.7+incompatible` |
| [github.com/docker/docker](https://github.com/docker/docker) | `24.0.6+incompatible` | `24.0.7+incompatible` |
| [github.com/go-git/go-git/v5](https://github.com/go-git/go-git) | `5.9.0` | `5.10.0` |
| [github.com/google/go-cmp](https://github.com/google/go-cmp) | `0.5.9` | `0.6.0` |
| [github.com/onsi/gomega](https://github.com/onsi/gomega) | `1.28.0` | `1.29.0` |
| [golang.org/x/oauth2](https://github.com/golang/oauth2) | `0.12.0` | `0.13.0` |

Updates `github.com/docker/cli` from 24.0.6+incompatible to 24.0.7+incompatible
- [Commits](docker/cli@v24.0.6...v24.0.7)

Updates `github.com/docker/docker` from 24.0.6+incompatible to 24.0.7+incompatible
- [Release notes](https://github.com/docker/docker/releases)
- [Commits](moby/moby@v24.0.6...v24.0.7)

Updates `github.com/go-git/go-git/v5` from 5.9.0 to 5.10.0
- [Release notes](https://github.com/go-git/go-git/releases)
- [Commits](go-git/go-git@v5.9.0...v5.10.0)

Updates `github.com/google/go-cmp` from 0.5.9 to 0.6.0
- [Release notes](https://github.com/google/go-cmp/releases)
- [Commits](google/go-cmp@v0.5.9...v0.6.0)

Updates `github.com/onsi/gomega` from 1.28.0 to 1.29.0
- [Release notes](https://github.com/onsi/gomega/releases)
- [Changelog](https://github.com/onsi/gomega/blob/master/CHANGELOG.md)
- [Commits](onsi/gomega@v1.28.0...v1.29.0)

Updates `golang.org/x/oauth2` from 0.12.0 to 0.13.0
- [Commits](golang/oauth2@v0.12.0...v0.13.0)

---
updated-dependencies:
- dependency-name: github.com/docker/cli
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: go-dependencies
- dependency-name: github.com/docker/docker
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: go-dependencies
- dependency-name: github.com/go-git/go-git/v5
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: go-dependencies
- dependency-name: github.com/google/go-cmp
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: go-dependencies
- dependency-name: github.com/onsi/gomega
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: go-dependencies
- dependency-name: golang.org/x/oauth2
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: go-dependencies
...

Signed-off-by: dependabot[bot] <[email protected]>
    @dependabot @WYGIN
    dependabot[bot] authored and WYGIN committed Nov 9, 2023
    Configuration menu
    Copy the full SHA
    0848fec View commit details
    Browse the repository at this point in the history

  27. Fix misleading log message when publishing a buildpack package 

    When using --publish it should say "saved to registry" not "saved to docker daemon"

Signed-off-by: Natalie Arellano <[email protected]>
    @natalieparellano @WYGIN
    natalieparellano authored and WYGIN committed Nov 9, 2023
    Configuration menu
    Copy the full SHA
    71821d8 View commit details
    Browse the repository at this point in the history

  28. WIP added code to generate env files in buildConfigEnv dir 

    Signed-off-by: WYGIN <[email protected]>
    @WYGIN
    WYGIN committed Nov 9, 2023
    Configuration menu
    Copy the full SHA
    4624639 View commit details
    Browse the repository at this point in the history

  29. WIP added required abstract test cases 

    Signed-off-by: WYGIN <[email protected]>
    @WYGIN
    WYGIN committed Nov 9, 2023
    Configuration menu
    Copy the full SHA
    9854231 View commit details
    Browse the repository at this point in the history

  30. WIP added tests that still nedd to be fixed 

    Signed-off-by: WYGIN <[email protected]>
    @WYGIN
    WYGIN committed Nov 9, 2023
    Configuration menu
    Copy the full SHA
    161d06a View commit details
    Browse the repository at this point in the history

  31. WIP change from action to suffix and delim in builder.toml 

    Signed-off-by: WYGIN <[email protected]>
    @WYGIN
    WYGIN committed Nov 9, 2023
    Configuration menu
    Copy the full SHA
    7183dcf View commit details
    Browse the repository at this point in the history

  32. WIP added logic to add buildConfigEnvs to layer of image 

    Signed-off-by: WYGIN <[email protected]>
    @WYGIN
    WYGIN committed Nov 9, 2023
    Configuration menu
    Copy the full SHA
    1480037 View commit details
    Browse the repository at this point in the history

  33. build-config-env layer oly added when it is not empty 

    Signed-off-by: WYGIN <[email protected]>
    @WYGIN
    WYGIN committed Nov 9, 2023
    Configuration menu
    Copy the full SHA
    b8409a9 View commit details
    Browse the repository at this point in the history

  34. added requested changes and fix bugs 

    Signed-off-by: WYGIN <[email protected]>
    @WYGIN
    WYGIN committed Nov 9, 2023
    Configuration menu
    Copy the full SHA
    fc47fd8 View commit details
    Browse the repository at this point in the history

  35. fix: code format 

    Signed-off-by: WYGIN <[email protected]>
    @WYGIN
    WYGIN committed Nov 9, 2023
    Configuration menu
    Copy the full SHA
    4feb437 View commit details
    Browse the repository at this point in the history

  36. improved code coverage 

    Signed-off-by: WYGIN <[email protected]>
    @WYGIN
    WYGIN committed Nov 9, 2023
    Configuration menu
    Copy the full SHA
    e41d99e View commit details
    Browse the repository at this point in the history

  37. build(deps): bump buildpacks/github-actions from 5.4.0 to 5.5.0 

    Bumps [buildpacks/github-actions](https://github.com/buildpacks/github-actions) from 5.4.0 to 5.5.0.
- [Release notes](https://github.com/buildpacks/github-actions/releases)
- [Commits](buildpacks/github-actions@v5.4.0...v5.5.0)

---
updated-dependencies:
- dependency-name: buildpacks/github-actions
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
    @dependabot @WYGIN
    dependabot[bot] authored and WYGIN committed Nov 9, 2023
    Configuration menu
    Copy the full SHA
    e3cc4d9 View commit details
    Browse the repository at this point in the history

  38. Add ServerVersion to docker client interface which is needed by imgutil 

    Signed-off-by: Jerico Pena <[email protected]>
    @jericop @WYGIN
    jericop authored and WYGIN committed Nov 9, 2023
    Configuration menu
    Copy the full SHA
    8e69f1b View commit details
    Browse the repository at this point in the history

  39. Use imgutil fork to verify platform changes 

    Signed-off-by: Jerico Pena <[email protected]>
    @jericop @WYGIN
    jericop authored and WYGIN committed Nov 9, 2023
    Configuration menu
    Copy the full SHA
    a8335fb View commit details
    Browse the repository at this point in the history

  40. Bump imgutil dependency for default platform change 

    Signed-off-by: Jerico Pena <[email protected]>
    @jericop @WYGIN
    jericop authored and WYGIN committed Nov 9, 2023
    Configuration menu
    Copy the full SHA
    f9ec20e View commit details
    Browse the repository at this point in the history

  41. WIP: added manifest_add command 

    Signed-off-by: WYGIN <[email protected]>
    @WYGIN
    WYGIN committed Nov 9, 2023
    Configuration menu
    Copy the full SHA
    b714626 View commit details
    Browse the repository at this point in the history

  42. WIP added manifest_annotate command 

    Signed-off-by: WYGIN <[email protected]>
    @WYGIN
    WYGIN committed Nov 9, 2023
    Configuration menu
    Copy the full SHA
    8b109bf View commit details
    Browse the repository at this point in the history

  43. WIP added manifest_create command 

    Signed-off-by: WYGIN <[email protected]>
    @WYGIN
    WYGIN committed Nov 9, 2023
    Configuration menu
    Copy the full SHA
    a76513d View commit details
    Browse the repository at this point in the history

  44. WIP added manifest_exists command 

    Signed-off-by: WYGIN <[email protected]>
    @WYGIN
    WYGIN committed Nov 9, 2023
    Configuration menu
    Copy the full SHA
    128f178 View commit details
    Browse the repository at this point in the history

  45. WIP added manifest_inspect command 

    Signed-off-by: WYGIN <[email protected]>
    @WYGIN
    WYGIN committed Nov 9, 2023
    Configuration menu
    Copy the full SHA
    d238c64 View commit details
    Browse the repository at this point in the history

  46. WIP added manifest_push command 

    Signed-off-by: WYGIN <[email protected]>
    @WYGIN
    WYGIN committed Nov 9, 2023
    Configuration menu
    Copy the full SHA
    9006ad4 View commit details
    Browse the repository at this point in the history

  47. WIP added manifest_remove command 

    Signed-off-by: WYGIN <[email protected]>
    @WYGIN
    WYGIN committed Nov 9, 2023
    Configuration menu
    Copy the full SHA
    11d416d View commit details
    Browse the repository at this point in the history

  48. WIP added manifest_rm command 

    Signed-off-by: WYGIN <[email protected]>
    @WYGIN
    WYGIN committed Nov 9, 2023
    Configuration menu
    Copy the full SHA
    749b6fe View commit details
    Browse the repository at this point in the history

  49. WIP added add_manifest client 

    Signed-off-by: WYGIN <[email protected]>
    @WYGIN
    WYGIN committed Nov 9, 2023
    Configuration menu
    Copy the full SHA
    8b25d63 View commit details
    Browse the repository at this point in the history

  50. WIP added annotate_manifest client 

    Signed-off-by: WYGIN <[email protected]>
    @WYGIN
    WYGIN committed Nov 9, 2023
    Configuration menu
    Copy the full SHA
    6b8f798 View commit details
    Browse the repository at this point in the history

  51. WIP added IndexFactory to Client 

    Signed-off-by: WYGIN <[email protected]>
    @WYGIN
    WYGIN committed Nov 9, 2023
    Configuration menu
    Copy the full SHA
    4aa9362 View commit details
    Browse the repository at this point in the history

  52. WIP added create_manifest client 

    Signed-off-by: WYGIN <[email protected]>
    @WYGIN
    WYGIN committed Nov 9, 2023
    Configuration menu
    Copy the full SHA
    89763fd View commit details
    Browse the repository at this point in the history

  53. WIP added delete_manifest client 

    Signed-off-by: WYGIN <[email protected]>
    @WYGIN
    WYGIN committed Nov 9, 2023
    Configuration menu
    Copy the full SHA
    a5b1faa View commit details
    Browse the repository at this point in the history

  54. WIP added exists_manifest client 

    Signed-off-by: WYGIN <[email protected]>
    @WYGIN
    WYGIN committed Nov 9, 2023
    Configuration menu
    Copy the full SHA
    6090d11 View commit details
    Browse the repository at this point in the history

  55. WIP added inspect_manifest client 

    Signed-off-by: WYGIN <[email protected]>
    @WYGIN
    WYGIN committed Nov 9, 2023
    Configuration menu
    Copy the full SHA
    b8f3186 View commit details
    Browse the repository at this point in the history

  56. WIP added push_manifest client 

    Signed-off-by: WYGIN <[email protected]>
    @WYGIN
    WYGIN committed Nov 9, 2023
    Configuration menu
    Copy the full SHA
    b9dd8a4 View commit details
    Browse the repository at this point in the history

  57. WIP added remove_manifest client 

    Signed-off-by: WYGIN <[email protected]>
    @WYGIN
    WYGIN committed Nov 9, 2023
    Configuration menu
    Copy the full SHA
    54c3c6c View commit details
    Browse the repository at this point in the history

  58. WIP added errors 

    Signed-off-by: WYGIN <[email protected]>

 Date:      Thu Nov 9 03:33:42 2023 +0000
    @WYGIN
    WYGIN committed Nov 9, 2023
    Configuration menu
    Copy the full SHA
    553f927 View commit details
    Browse the repository at this point in the history

  59. Merge branch 'manifest' of https://github.com/WYGIN/buildpacks-pack i… 

    …nto manifest
    @WYGIN
    WYGIN committed Nov 9, 2023
    Configuration menu
    Copy the full SHA
    c7180d8 View commit details
    Browse the repository at this point in the history

  60. WIP generate mock code with 'make generate' 

    Signed-off-by: WYGIN <[email protected]>
    @WYGIN
    WYGIN committed Nov 9, 2023
    Configuration menu
    Copy the full SHA
    4bbb483 View commit details
    Browse the repository at this point in the history

  61. WIP added tests for add_manifest 

    Signed-off-by: WYGIN <[email protected]>
    @WYGIN
    WYGIN committed Nov 9, 2023
    Configuration menu
    Copy the full SHA
    8f81b6c View commit details
    Browse the repository at this point in the history

Commits on Nov 10, 2023

  1. WIP improved add_manifest client tests 

    Signed-off-by: WYGIN <[email protected]>
    @WYGIN
    WYGIN committed Nov 10, 2023
    Configuration menu
    Copy the full SHA
    f12c849 View commit details
    Browse the repository at this point in the history

  2. WIP refactor manifest_add client 

    Signed-off-by: WYGIN <[email protected]>
    @WYGIN
    WYGIN committed Nov 10, 2023
    Configuration menu
    Copy the full SHA
    4326812 View commit details
    Browse the repository at this point in the history