Suggest/trust heroku/builder:20 instead of heroku/buildpacks:20
#1924
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
type/enhancement
The `heroku/buildpacks:20` builder has been superseded by `heroku/builder:20`, and the old builder is about to be deprecated: heroku/cnb-builder-images#394 https://github.com/heroku/cnb-builder-images/blob/main/README.md As such, the suggested/trusted builders list has been updated accordingly. I've also tweaked the Heroku builder descriptions to: - mention the underlying Linux distro - fix the alphabetical ordering of supported buildpack languages Signed-off-by: Ed Morley <[email protected]>
edmorley
force-pushed
the
heroku-builder-20
branch
from
15a3a51 to
7bf91e7
Compare
|
CI is failing in ways that seem unrelated to my changes, eg: Retriggering didn't help. Is this because PRs from forks aren't supported, or am I missing something? :-) |
edmorley
added a commit
to edmorley/tekton-integration
that referenced
this pull request
Oct 3, 2023
The `heroku/buildpacks:*` builders have been replaced by `heroku/builder:*` and the former are about to be deprecated. See: https://github.com/heroku/cnb-builder-images/blob/main/README.md buildpacks/pack#1924
edmorley
added a commit
to edmorley/tekton-integration
that referenced
this pull request
Oct 3, 2023
The `heroku/buildpacks:*` builders have been replaced by `heroku/builder:*` and the former are about to be deprecated. See: https://github.com/heroku/cnb-builder-images/blob/main/README.md buildpacks/pack#1924 Signed-off-by: Ed Morley <[email protected]>
I don't think so, I also saw another PR (#1921) failing for the same reason, I am trying to take a look on what is going on |
|
Please can someone merge this for me? It has approval, but I don't have permissions to merge :-) |
|
@buildpacks/platform-maintainers ^^ |
jkutner
approved these changes
Oct 16, 2023
edmorley
added a commit
to edmorley/tekton-integration
that referenced
this pull request
Mar 12, 2024
The `heroku/buildpacks:*` builders have been replaced by `heroku/builder:*` and the former are about to be deprecated. See: https://github.com/heroku/cnb-builder-images/blob/main/README.md buildpacks/pack#1924 Signed-off-by: Ed Morley <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
heroku/buildpacks:20builder has been superseded byheroku/builder:20, and the old builder is about to be deprecated:heroku/cnb-builder-images#394
https://github.com/heroku/cnb-builder-images/blob/main/README.md
As such, the suggested/trusted builders list has been updated accordingly.
I've also tweaked the Heroku builder descriptions to: