Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stack fix & create new volume cache for kaniko instead of re-using build cache #1789

Merged
merged 10 commits into from
Jun 21, 2023
Merged

Stack fix & create new volume cache for kaniko instead of re-using build cache #1789

merged 10 commits into from
Jun 21, 2023

Conversation

natalieparellano
Copy link
Member

This removes the unnecessary restriction that the build cache must be a volume cache in order to use extensions.

@natalieparellano
Create new volume cache for kaniko instead of re-using build cache
63d1592 
This removes the unnecessary restriction that the build cache must be a volume cache
in order to use extensions.

Signed-off-by: Natalie Arellano <[email protected]>
@natalieparellano natalieparellano requested review from a team as code owners May 30, 2023 21:55
@github-actions github-actions bot added the type/enhancement Issue that requests a new feature or improvement. label May 30, 2023
@github-actions github-actions bot added this to the 0.30.0 milestone May 30, 2023
@natalieparellano natalieparellano mentioned this pull request May 30, 2023
Closed
5 tasks
natalieparellano
natalieparellano commented May 30, 2023
View reviewed changes
pkg/cache/cache_opts.go
Comment on lines +147 to +155
if c.Build.Format == CacheBind {
if resolvedPath, err = filepath.Abs(c.Build.Source); err != nil {
return errors.Wrap(err, "resolve absolute path")
}
c.Build.Source = filepath.Join(resolvedPath, "build-cache")
}
if c.Launch.Format == CacheBind {
if resolvedPath, err = filepath.Abs(c.Launch.Source); err != nil {
return errors.Wrap(err, "resolve absolute path")
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Totally unrelated change... I can pull it out of this PR if desired. Looking through the code it seems the current implementation unnecessarily skips resolving the launch cache when the build cache is a bind.

@jjbustamante jjbustamante added type/bug Issue that reports an unexpected behaviour. and removed type/enhancement Issue that requests a new feature or improvement. labels Jun 7, 2023
@jjbustamante
Copy link
Member

@natalieparellano

I can see you have the following error message during the test execution:

ERROR: failed to read builder image: failed to create cache directory: mkdir /kaniko/cache: permission denied

I have something similar in my flattened fixes PR, do you have any thoughts on root cause for that?

@natalieparellano natalieparellano mentioned this pull request Jun 7, 2023
Merged
@natalieparellano
Copy link
Member Author

Thanks for the review @jjbustamante! This looks to be an issue in the lifecycle - I put up buildpacks/lifecycle#1117

@natalieparellano
Copy link
Member Author

I've confirmed manually that lifecycle built from main together with the fix from #1795 should cause the test that's currently failing to go green; when lifecycle 0.17.0-rc.1 is out, we can update this PR to point to the lifecycle release candidate in DefaultLifecycleVersion

@natalieparellano
Merge pull request #1795 from joe-kimmel-vmw/nostacksforyou
46ba61f 
only add the stack arg to lifecycle for older platform APIs
@github-actions github-actions bot added the type/enhancement Issue that requests a new feature or improvement. label Jun 15, 2023
@natalieparellano
Fix acceptance
3be39f9 
Signed-off-by: Natalie Arellano <[email protected]>
@github-actions github-actions bot added the type/chore Issue that requests non-user facing changes. label Jun 15, 2023
@natalieparellano
Fix extension
c965586 
Signed-off-by: Natalie Arellano <[email protected]>
@natalieparellano
Fix acceptance
57fd8c1 
The fixture changed, so its SHA changed

Signed-off-by: Natalie Arellano <[email protected]>
@natalieparellano natalieparellano changed the title Create new volume cache for kaniko instead of re-using build cache Stack fix & create new volume cache for kaniko instead of re-using build cache Jun 16, 2023
@natalieparellano natalieparellano mentioned this pull request Jun 16, 2023
Closed
1 task
@natalieparellano
Fallback to old behavior of re-using the build cache on older platfor…
e618ace 
…m api

Without this change, users would be required to upgrade their lifecycle to 0.17.0
when consuming pack 0.30.0 if using build image extension,
as the restorer would fail to write to the /kaniko directory.

Signed-off-by: Natalie Arellano <[email protected]>
@natalieparellano
Add unit test
edc796f 
Signed-off-by: Natalie Arellano <[email protected]>
@jkutner jkutner enabled auto-merge June 21, 2023 15:49
@jkutner jkutner merged commit 21b9a3a into main Jun 21, 2023
@jkutner jkutner deleted the fix/kaniko-cache branch June 21, 2023 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkutner jkutner jkutner approved these changes

@jjbustamante jjbustamante Awaiting requested review from jjbustamante

Assignees
No one assigned
Labels
type/bug Issue that reports an unexpected behaviour. type/chore Issue that requests non-user facing changes. type/enhancement Issue that requests a new feature or improvement.
Projects
None yet
Milestone
0.30.0
Development

Successfully merging this pull request may close these issues.
4 participants
@natalieparellano @jjbustamante @jkutner @joe-kimmel-vmw