Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove deprecated suggest-stacks command #1714

Merged
merged 1 commit into from
Apr 10, 2023
Merged

remove deprecated suggest-stacks command #1714

merged 1 commit into from
Apr 10, 2023

Conversation

joe-kimmel-vmw
Copy link
Contributor

@joe-kimmel-vmw joe-kimmel-vmw commented Apr 7, 2023 •
edited
Loading

Summary

removes code that has been deprecated for over 2 years

Output

Before

> pack suggest-stacks
Warning: Command pack suggest-stacks has been deprecated, please use pack stack suggest instead
[same output as pack stack suggest]

After

>pack suggest-stacks
Error: unknown command "suggest-stacks" for "pack"
Run 'pack --help' for usage.

Documentation

There are no official CNB docs but a quick google research returns a few docs owned by external parties.
https://www.google.com/search?q=cnb+%22pack+suggest-stacks%22&rlz=1C5GCEA_enUS988US988&oq=cnb+%22pack+suggest-stacks%22

of those, the only one that is "official docs" (as opposed to a blog post) is :
https://cloud.google.com/migrate/kf/docs/2.1/how-to/customizing-buildpacks

which is specifically for version 2.1, marked as EOL/unsupported.

  • Should this change be documented?
    • Yes, see #___
    • No

Related

Resolves #___

@github-actions github-actions bot added this to the 0.30.0 milestone Apr 7, 2023
@github-actions github-actions bot added the type/enhancement Issue that requests a new feature or improvement. label Apr 7, 2023
@joe-kimmel-vmw joe-kimmel-vmw marked this pull request as ready for review April 7, 2023 19:18
@joe-kimmel-vmw joe-kimmel-vmw requested review from a team as code owners April 7, 2023 19:18
@jkutner jkutner merged commit 81ef9c2 into buildpacks:main Apr 10, 2023
@joe-kimmel-vmw joe-kimmel-vmw deleted the terminate_the_deprecated branch April 10, 2023 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkutner jkutner jkutner approved these changes

Assignees
No one assigned
Labels
type/enhancement Issue that requests a new feature or improvement.
Projects
None yet
Milestone
0.30.0
Development

Successfully merging this pull request may close these issues.
2 participants
@joe-kimmel-vmw @jkutner