Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump golang.org/x/crypto to 7b82a4e #1420

Merged
merged 3 commits into from
Apr 25, 2022
Merged

Conversation

lsm5
Copy link
Contributor

@lsm5 lsm5 commented Apr 13, 2022

Resolves: GHSA-8c26-wmh5-6g9v - CVE-2022-27191

golang.org/x/crypto@1baeb1ce contains the actual CVE fix. Using the
latest upstream commit to also include support for SHA-2.

I haven't investigated if pack is vulnerable to this CVE but figured it
won't hurt to bump to the latest commit.

Signed-off-by: Lokesh Mandvekar [email protected]

(I can update the description per the format below, but I don't have anything specific (yet).)

Summary

Output

Before

After

Documentation

  • Should this change be documented?
    • Yes, see #___
    • No

Related

Resolves #___

Resolves: GHSA-8c26-wmh5-6g9v - CVE-2022-27191

golang.org/x/crypto@1baeb1ce contains the actual CVE fix. Using the
latest upstream commit to also include support for SHA-2.

I haven't investigated if pack is vulnerable to this CVE but figured it
won't hurt to bump to the latest commit.

Signed-off-by: Lokesh Mandvekar <[email protected]>
@lsm5 lsm5 requested a review from a team as a code owner April 13, 2022 12:18
@github-actions github-actions bot added the type/chore Issue that requests non-user facing changes. label Apr 13, 2022
@github-actions github-actions bot added this to the 0.25.0 milestone Apr 13, 2022
@dfreilich dfreilich modified the milestones: 0.25.0, 0.26.0 Apr 15, 2022
@jromero
Copy link
Member

jromero commented Apr 21, 2022

Hi @lsm5,

Thank you for bringing this to our attention. It seems like our CI/CD linting processes detected a few deprecated variables being used/imported.

Would you be able to update their use as well?

@jromero jromero added dependencies Pull requests that update a dependency file go Pull requests that update Go code labels Apr 21, 2022
Also:
- Update golang-ci lint configucation

Signed-off-by: Javier Romero <[email protected]>
@github-actions github-actions bot added the type/enhancement Issue that requests a new feature or improvement. label Apr 25, 2022
@jromero jromero enabled auto-merge April 25, 2022 22:41
@jromero jromero merged commit 7fd6dd0 into buildpacks:main Apr 25, 2022
@lsm5
Copy link
Contributor Author

lsm5 commented Apr 29, 2022

err whoops, totally missed this. Thanks for picking up the slack @jromero . I'll build this for fedora.

@lsm5
Copy link
Contributor Author

lsm5 commented Apr 29, 2022

@jromero can we get a new version tag cut with this fix included? That would make fedora building much easier.

@lsm5 lsm5 deleted the main-cve-2022-27191 branch April 29, 2022 14:30
@jromero
Copy link
Member

jromero commented Apr 29, 2022

https://cloud-native.slack.com/archives/C033DV9CSAD/p1651264821374099?thread_ts=1651264821.374099&cid=C033DV9CSAD

TLDR; it may take up to mid next week due to availability.

Hope that's okay.

@lsm5
Copy link
Contributor Author

lsm5 commented Apr 30, 2022

https://cloud-native.slack.com/archives/C033DV9CSAD/p1651264821374099?thread_ts=1651264821.374099&cid=C033DV9CSAD

TLDR; it may take up to mid next week due to availability.

Hope that's okay.

works for me, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file go Pull requests that update Go code type/chore Issue that requests non-user facing changes. type/enhancement Issue that requests a new feature or improvement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants