Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show SBOMs in interactive pane #1349

Merged
merged 2 commits into from
Jan 24, 2022
Merged

Show SBOMs in interactive pane #1349

merged 2 commits into from
Jan 24, 2022

Conversation

aemengo
Copy link
Contributor

@aemengo aemengo commented Dec 20, 2021 •
edited by matthewmcnew
Loading

Summary

Screen Shot 2021-12-20 at 12 26 28 PM

Documentation

  • Should this change be documented?
    • Yes, see #___
    • No

Related

#1335

@github-actions github-actions bot added this to the 0.23.0 milestone Dec 20, 2021
@github-actions github-actions bot added the type/enhancement Issue that requests a new feature or improvement. label Dec 20, 2021
@codecov
Copy link

codecov bot commented Dec 20, 2021 •
edited
Loading

Codecov Report

Merging #1349 (45c726f) into main (f046f79) will decrease coverage by 0.02%.
The diff coverage is 59.62%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1349      +/-   ##
==========================================
- Coverage   81.54%   81.53%   -0.01%     
==========================================
  Files         146      146              
  Lines        9534     9568      +34     
==========================================
+ Hits         7774     7800      +26     
- Misses       1296     1303       +7     
- Partials      464      465       +1
Flag Coverage Δ
os_linux 80.26% <59.62%> (-0.01%) ⬇️
os_macos 77.64% <59.62%> (-<0.01%) ⬇️
os_windows 81.40% <59.62%> (-0.01%) ⬇️
unit 81.53% <59.62%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Show SBOMs in interactive pane
8934882 
- Also show buildpacks in interactive pane, even if not present in builder

Signed-off-by: Anthony Emengo <[email protected]>
@aemengo aemengo marked this pull request as ready for review December 21, 2021 23:11
@aemengo aemengo requested a review from a team as a code owner December 21, 2021 23:11
@dfreilich dfreilich modified the milestones: 0.23.0, 0.24.0 Jan 3, 2022
@aemengo aemengo mentioned this pull request Jan 18, 2022
Closed
dfreilich
dfreilich approved these changes Jan 24, 2022
View reviewed changes
Copy link
Member

@dfreilich dfreilich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dfreilich dfreilich merged commit 3fc8e22 into buildpacks:main Jan 24, 2022
@aemengo aemengo deleted the visualize-sbom branch January 25, 2022 00:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dfreilich dfreilich dfreilich approved these changes

Assignees
No one assigned
Labels
type/enhancement Issue that requests a new feature or improvement.
Projects
None yet
Milestone
0.24.0
Development

Successfully merging this pull request may close these issues.
2 participants
@aemengo @dfreilich