Remove outdated acceptance tests constraints #1340
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: David Freilich <[email protected]>
github-actions
bot
added
type/chore
Signed-off-by: David Freilich <[email protected]>
dfreilich
force-pushed
the
clean-remove-old-pack-constraints
branch
from
23d4887
to
07dd22f
Compare
dfreilich
changed the title
jromero
approved these changes
Dec 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Pack tests the current state of the code, and pulls the latest tag for the compatibility tests. We sometimes include constraints in our acceptance tests in order to ensure that we can account for changes between versions, but we only need to keep the constraint for
n-1versions; this PR prunes some old acceptance constraints, to simplify the code paths.