Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Polish #1241 #1261

Merged
merged 4 commits into from
Aug 18, 2021
Merged

Polish #1241 #1261

merged 4 commits into from
Aug 18, 2021

Conversation

jromero
Copy link
Member

@jromero jromero commented Aug 18, 2021

This is a polishing PR for original #1241 by @YousefHaggyHeroku.

Changes:

  1. Incorporate changes described in comment
  2. Rename common to types
  3. Remove dependency on internal
  4. Move to pkg
  5. Resolve conflicts with origin/main

The intent of this PR is solely to provide minor changes to the original in an effort to reduce friction in the review and merging process. As author of the original PR, if there are any questions, comments, or concerns, don't hesitate to reach out to the maintainers.

@jromero jromero requested a review from a team as a code owner August 18, 2021 17:52
@github-actions github-actions bot added this to the 0.21.0 milestone Aug 18, 2021
@github-actions github-actions bot added the type/enhancement Issue that requests a new feature or improvement. label Aug 18, 2021
@codecov
Copy link

codecov bot commented Aug 18, 2021

Codecov Report

Merging #1261 (efffe58) into main (74fbe47) will decrease coverage by 0.04%.
The diff coverage is 81.64%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1261      +/-   ##
==========================================
- Coverage   81.23%   81.19%   -0.03%     
==========================================
  Files         140      140              
  Lines        8582     8596      +14     
==========================================
+ Hits         6971     6979       +8     
- Misses       1176     1180       +4     
- Partials      435      437       +2     
Flag Coverage Δ
os_linux 79.83% <81.64%> (-<0.01%) ⬇️
os_macos 77.08% <10.21%> (-0.12%) ⬇️
os_windows 81.09% <81.64%> (-0.03%) ⬇️
unit 81.19% <81.64%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@jromero jromero merged commit d52405e into main Aug 18, 2021
@jromero jromero deleted the polish/1241 branch August 18, 2021 21:16
@jromero jromero added type/chore Issue that requests non-user facing changes. and removed type/enhancement Issue that requests a new feature or improvement. labels Sep 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/chore Issue that requests non-user facing changes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants