Add registry mirror support for pack build #1210

aemengo · 2021-06-16T21:27:13Z

Summary

Add support for a registry mirroring during pack build command. The use-case being enterprise environments where public registry access is denied.

If pack's config.toml is configured like:

[registry-mirrors]
  "index.docker.io" = "nexus.mycompany.local/mirror"

Then requests from registriespaketobuildpacks/builder will be turned into nexus.mycompany.local/mirror/paketobuildpacks/builder

This PR also adds the config subcommands to manipulate these entries to config.toml.

Output

Before

$ pack build aemengo/hello
full: Pulling from paketobuildpacks/builder
Digest: sha256:2917564c2de52debd1df70d11c014b2708c8974e6e853804958825be84cfb859
Status: Image is up to date for paketobuildpacks/builder:full
...

After

$ pack build aemengo/hello
full: Pulling from mirror/paketobuildpacks/builder
Digest: sha256:2917564c2de52debd1df70d11c014b2708c8974e6e853804958825be84cfb859
Status: Image is up to date for nexus.mycompany.local/mirror/dockerhub-mirror/paketobuildpacks/builder:full
...

Caveats

The user entered image-tag is not modified. Not sure if this is desired behavior or not. 🤷🏾‍♂️

Documentation

Should this change be documented?
- Yes, see #___
- No

Codecov Report

Merging #1210 (95ed976) into main (9df4e6b) will increase coverage by 0.05%.
The diff coverage is 84.56%.

@@            Coverage Diff             @@
##             main    #1210      +/-   ##
==========================================
+ Coverage   80.96%   81.00%   +0.05%     
==========================================
  Files         136      138       +2     
  Lines        8316     8435     +119     
==========================================
+ Hits         6732     6832     +100     
- Misses       1158     1172      +14     
- Partials      426      431       +5

Flag	Coverage Δ
os_linux	`80.67% <87.78%> (+0.18%)`	⬆️
os_macos	`78.13% <83.34%> (+0.10%)`	⬆️
os_windows	`80.92% <84.56%> (+0.05%)`	⬆️
unit	`80.67% <87.78%> (+0.10%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

aemengo · 2021-06-24T19:48:51Z

internal/image/fetcher.go

+	name, err := pname.TranslateRegistry(name, f.registryMirrors)
+	if err != nil {
+		return nil, err
+	}


Just acknowledging that this line isn't tested. 😕

jromero · 2021-06-29T13:08:33Z

The implemented proxy per host or base url is interesting.

[registry-mirrors]
  "index.docker.io" = "nexus.mycompany.local/mirror"
  "gcr.io/some/path" = "nexus.mycompany.local/mirror"

I'm not sure where that requirement came from (I see it in the example config comment here) but mirrors are more commonly applied globally to any and all dependencies. I'd want to validate that this feature request does need a per host/base url type configuration.

If it does, we'll need a wildcard proxy so it works across any and all images.
```
[registry-mirrors]
  "*" = "nexus.mycompany.local/mirror"
```
If there isn't a current requirement for per host/base url, I would remove it to reduce complexity.

Reference:

maven < 2.0.5: classic setup
maven >= 2.0.5: mirrorOf wildcard
npm: default registry and scoped packages (scoped packages are like namespaces - analogous to base url)

EDIT: Based on my comment and additional research I've been doing I think it's worth having the per host/base url mirrors BUT we should implement the wildcard option.

aemengo · 2021-06-29T13:25:41Z

@jromero This flexibility for per host/base url came from my experience using harbor as a proxy cache.

At the very least, clients using the proxy cache feature of Harbor cannot set a global mirror.

jromero · 2021-06-29T13:50:52Z

TL;DR: we want both per base urls and wildcard (any).

That makes sense although it does appear to be a harbor specific limitation.

FWIW, the global mirror I was referring to is declared at the client side (pack in this case). It basically says, "for any image, I want you to go look it up at this registry" (ie. Harbor or Artifactory), then it's up to configuration in the registry to look up that image in configured remote (delegated) registries. In Artifactory's case you can setup multiple registries it can delegate/proxy so as a client you want "any" support so that it's up to the Artifactory to do the look up without having to manually map all base urls at the client side.

dfreilich

This is really super for my current use case, where I want to ensure all of our requests are proxied to Artifactory. Really happy to see this work @aemengo; superb as always.

One very confusing aspect of it for me, in UA, was the fetcher doesn't immediately say that it's pulling from the mirror. I cancelled it a number of times, because I didn't think I had set my mirror appropriately, until I got to the Status line and saw that it did work appropriately. If you could make the image mirror explicit from the beginning, that would make the UX for me significantly better.

$ out/pack build test-go -B paketobuildpacks/builder:tiny -p ../paketo-samples/go/mod
tiny: Pulling from paketobuildpacks/builder
b734f5039f3d: Pull complete
...
Digest: sha256:e6e5fcd7c7094ed28f45b98e1528303f0f3304696e6bd737537c838cdd8f463f
Status: Downloaded newer image for <Artifactory-mirror>/paketobuildpacks/builder:tiny
tiny-cnb: Pulling from paketobuildpacks/run
4fb75c639a6b: Pull complete
...
Digest: sha256:b643257f93f44aa4e77c1c746fea14f419e29a2123829c7a228bc7f1b633fe2a
Status: Downloaded newer image for <Artifactory Mirror>/paketobuildpacks/run:tiny-cnb
...

If we could change the Pulling from line to also reflect the registries mirror, that would be a slam-dunk from my end

internal/commands/config_registry_mirrors.go

Also adds a new config subcommand for registry-mirrors Signed-off-by: Anthony Emengo <[email protected]>

* Support wildcard registry mirror * Add registry-mirror alias Signed-off-by: Anthony Emengo <[email protected]>

aemengo · 2021-07-06T19:48:54Z

@dfreilich

If we could change the Pulling from line to also reflect the registries mirror, that would be a slam-dunk from my end

It looks like we're not writing that line, it's being feed to us by the docker API. I don't know how you still feel about replacing it. To me, it's a bit unsavory.

Maybe a big yellow text WARNING: using mirror <Artifactory-mirror> is better?

EDIT: see 95ed9769

$ pack build
Using mirror <MY-MIRROR>/dockerhub-mirror/paketobuildpacks/builder:full for index.docker.io/paketobuildpacks/builder:full
full: Pulling from dockerhub-mirror/paketobuildpacks/builder
Digest: sha256:7190dbb8177139fbfcdf9445f03420aaaa94832d8b3084e1a34870b11cf0d102
Status: Image is up to date for <MY-MIRROR>/dockerhub-mirror/paketobuildpacks/builder:full
Using mirror <MY-MIRROR>/dockerhub-mirror/paketobuildpacks/run:full-cnb for index.docker.io/paketobuildpacks/run:full-cnb
full-cnb: Pulling from dockerhub-mirror/paketobuildpacks/run
Digest: sha256:65972587451d7a0b6a375f9e39573c4272add20ce1c6a82c7d195e9e915e2796
Status: Image is up to date for <MY-MIRROR>/dockerhub-mirror/paketobuildpacks/run:full-cnb
Using mirror <MY-MIRROR>/dockerhub-mirror/paketobuildpacks/run:full-cnb for index.docker.io/paketobuildpacks/run:full-cnb
===> DETECTING
3 of 6 buildpacks participating
paketo-buildpacks/ca-certificates 2.3.2
paketo-buildpacks/go-dist         0.5.1
paketo-buildpacks/go-build        0.3.4
...

Signed-off-by: Anthony Emengo <[email protected]>

dfreilich

Beautiful work. Thanks!

aemengo requested a review from a team as a code owner June 16, 2021 21:27

aemengo marked this pull request as draft June 16, 2021 21:27

github-actions bot added this to the 0.20.0 milestone Jun 16, 2021

github-actions bot added the type/enhancement Issue that requests a new feature or improvement. label Jun 16, 2021

aemengo changed the title ~~wip~~ Add registry mirror support for pack build Jun 16, 2021

aemengo force-pushed the registry-mirror-support branch from 40ef1f0 to 10397ec Compare June 16, 2021 21:29

aemengo force-pushed the registry-mirror-support branch 4 times, most recently from bccf755 to 7d38c24 Compare June 24, 2021 18:44

aemengo commented Jun 24, 2021

View reviewed changes

aemengo marked this pull request as ready for review June 24, 2021 19:52

aemengo force-pushed the registry-mirror-support branch from 7d38c24 to c039c75 Compare June 29, 2021 13:30

aemengo force-pushed the registry-mirror-support branch from c039c75 to 3f61659 Compare June 29, 2021 20:09

dfreilich requested changes Jul 2, 2021

View reviewed changes

internal/commands/config_registry_mirrors.go Outdated Show resolved Hide resolved

internal/commands/config_registry_mirrors.go Outdated Show resolved Hide resolved

internal/commands/config_registry_mirrors.go Outdated Show resolved Hide resolved

dfreilich mentioned this pull request Jul 4, 2021

Add a registry pull proxy #1191

Closed

2 tasks

Support registry mirror during build

4d1ea11

Also adds a new config subcommand for registry-mirrors Signed-off-by: Anthony Emengo <[email protected]>

aemengo force-pushed the registry-mirror-support branch from 3f61659 to 9ed36d7 Compare July 6, 2021 18:28

Address PR review comments

cfdac4a

* Support wildcard registry mirror * Add registry-mirror alias Signed-off-by: Anthony Emengo <[email protected]>

aemengo force-pushed the registry-mirror-support branch from 9ed36d7 to cfdac4a Compare July 6, 2021 19:06

Log when mirrorred ref is used

95ed976

Signed-off-by: Anthony Emengo <[email protected]>

dfreilich approved these changes Jul 11, 2021

View reviewed changes

dfreilich merged commit d44736c into buildpacks:main Jul 11, 2021

scottfrederick mentioned this pull request May 3, 2022

Support registry mirrors when building images spring-projects/spring-boot#30852

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add registry mirror support for pack build #1210

Add registry mirror support for pack build #1210

aemengo commented Jun 16, 2021 •

edited

Loading

codecov bot commented Jun 16, 2021 •

edited

Loading

aemengo Jun 24, 2021

jromero commented Jun 29, 2021 •

edited

Loading

aemengo commented Jun 29, 2021

jromero commented Jun 29, 2021

dfreilich left a comment •

edited

Loading

aemengo commented Jul 6, 2021 •

edited

Loading

dfreilich left a comment

Add registry mirror support for pack build #1210

Add registry mirror support for pack build #1210

Conversation

aemengo commented Jun 16, 2021 • edited Loading

Summary

Output

Before

After

Caveats

Documentation

Related

codecov bot commented Jun 16, 2021 • edited Loading

Codecov Report

aemengo Jun 24, 2021

Choose a reason for hiding this comment

jromero commented Jun 29, 2021 • edited Loading

aemengo commented Jun 29, 2021

jromero commented Jun 29, 2021

dfreilich left a comment • edited Loading

Choose a reason for hiding this comment

aemengo commented Jul 6, 2021 • edited Loading

dfreilich left a comment

Choose a reason for hiding this comment

aemengo commented Jun 16, 2021 •

edited

Loading

codecov bot commented Jun 16, 2021 •

edited

Loading

jromero commented Jun 29, 2021 •

edited

Loading

dfreilich left a comment •

edited

Loading

aemengo commented Jul 6, 2021 •

edited

Loading