Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

no windows build! #29

Closed
kennethreitz opened this issue Sep 20, 2018 · 5 comments
Closed

no windows build! #29

kennethreitz opened this issue Sep 20, 2018 · 5 comments
Assignees
@ekcasey

Comments

@kennethreitz
Copy link

it'd be nice! I can try to introduce you to people at Microsoft if you need resources.
@sclevine
Copy link
Member

We definitely plan to have builds for Linux, macOS, and Windows available soon.

Worth noting that we don't have immediate plans to support Windows containers. (The spec will need to define how Windows buildpacks should work first.)

@ssisil
Copy link

ssisil commented Oct 4, 2018 •
edited
Loading

Acceptance Criteria :

WHEN I have download a windows binary of the pack cli from the CI pipeline
AND make it executable
THEN I can run any of the following commands :

  • pack build
  • pack create-builder
  • pack [add|update|delete]-stack

AND the cli should perform like it does on linux and macos binaries

@jchesterpivotal
Copy link
Contributor

Based on our manual prodding, this is broken, regardless of how the path is written (eg, quoted or unquoted, \ or \\).

Of interest the sample Nodejs buildpack says "fail" (our current way of saying "not detected"), but the sample Java buildpack errors (exits 1). It's not clear to me if that indicates something or is coincidental.

My current hunch is that something about our file-copying logic is misfiring.

One theory: Microsoft's documentation suggests that for Docker on Windows, forward slashes in paths are expected, but backslashes (the Windows standard) are not supported. In a number of places we use the filepath package from the go standard library, which picks the path separator (/ or \) according to the operating system. If it is providing backslashes and if this is tripping up Docker for Windows, that may be the issue.

@dgodd
Copy link
Contributor

dgodd commented Oct 29, 2018 •
edited
Loading

@ssisil We should probably skip build with buildpack dir for the MVP for windows? Windows doesn't simply provide executable bits for the bin/detect files. We could special case, but I'm not sure that is the best behavior

Also applies to create-builder.

Suggestion: Disable and show good error.

@ekcasey ekcasey assigned ekcasey and unassigned dgodd and ameyer-pivotal Nov 5, 2018
dgodd added a commit that referenced this issue Nov 23, 2018
@dgodd
Add appveyor.yml for windows builds
eba23ce 
- Disable 'create-builder' from directories
- Disable tests which require 'create-builder' for directories
- Switch test that assumes "USER" env variables is set to use "PATH"
  (on windows the user env var is "USERNAME", everything has "PATH")

See: https://ci.appveyor.com/project/dgodd/pack

[#29]
@dgodd
Copy link
Contributor

dgodd commented Nov 23, 2018 •
edited
Loading

@ssisil As discussed all but create-builder works. CI is on appveyor, and the built binary is under artifacts on appveyor; see: https://ci.appveyor.com/project/dgodd/pack/builds/20514268/artifacts

@ssisil ssisil closed this as completed Nov 26, 2018
natalieparellano added a commit that referenced this issue Jul 17, 2024
@natalieparellano
Merge pull request #29 from buildpacks/fix/userns
dded2a0 
Run build containers with updated settings
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ekcasey ekcasey

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
7 participants
@kennethreitz @dgodd @sclevine @ekcasey @jchesterpivotal @ameyer-pivotal @ssisil