-
Notifications
You must be signed in to change notification settings - Fork 286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run images are not pulled when using extensions #1686
Comments
@mhdawson thanks for the issue - I think the solution you are describing makes sense. |
Should be fixed when #1730 lands |
@natalieparellano thanks for the update. |
Pulling run images manually is no longer required after buildpacks/pack#1686 was fixed. Signed-off-by: Michael Dawson <[email protected]>
@natalieparellano validated that it now works and submitted PR to update instructions for extension to remove step that said to pull the images - paketo-community/ubi-nodejs-extension#2 |
Summary
We've been working on a Node.js extension to support ubi. We have been able to
build an extension and a builder that uses it and its in https://github.com/nodeshift/ubi-nodejs-extension,
along with instructions on how to try it out.
One issue which I came across which I
think
is a bug in pack is that the run images thatan exention switches to are not automatically pulled by pack. This means that the user needs
to pull them in advance ( step 7 in https://github.com/nodeshift/ubi-nodejs-extension/blob/main/README.md#usage).
I don't think the user should have to know the full set of possible images for the run image and have
to pull them all down in advance.
Reproductions
Steps
Follow the steps in https://github.com/nodeshift/ubi-nodejs-extension/blob/main/README.md#usage and omit step 7.
Current behavior
An error is returned indicating the top level app image is empty (which was confusing to me)
Expected behavior
The run image is automatically pulled and the application builds successfully.
Environment
pack info
user1@fedora testit]$ pack report Pack: Version: 0.28.0+git-b10e41f.build-3729 OS/Arch: linux/amd64 Default Lifecycle Version: 0.15.2 Supported Platform APIs: 0.3, 0.4, 0.5, 0.6, 0.7, 0.8, 0.9, 0.10 Config: default-builder-image = "[REDACTED]"
docker info
The text was updated successfully, but these errors were encountered: