Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pack build #1

Closed
ekcasey opened this issue Aug 6, 2018 · 3 comments
Closed

pack build #1

ekcasey opened this issue Aug 6, 2018 · 3 comments
Assignees
Labels
type/enhancement Issue that requests a new feature or improvement.

Comments

@ekcasey
Copy link
Member

ekcasey commented Aug 6, 2018

pack build

As a developer I want to use the pack buildcommand to create an image so that I can build my app using buildpacks, and run it similarly to how it will run in production

Acceptance Criteria

Given I have installed docker
Given Source code in a directory <app-dir>
When I run pack build --dir <app-dir> --name <repo-name>:<tag-name (optional)>
Then The pack cli builds an image from the source code in <app-dir> with the v3 buildpack lifecycle and puts it in <repo-name> in the local Docker daemon
Then I can run docker run ` and see my app running

Assumptions

  1. For this first story we assume the image is fetched from and written to the docker daemon
  2. We can skip restorer and cacher in this first iteration
  3. We can assume the correct stack is packs/v3 on dockerhub
@ekcasey ekcasey added the type/enhancement Issue that requests a new feature or improvement. label Aug 6, 2018
@ekcasey ekcasey self-assigned this Aug 6, 2018
@dgodd
Copy link
Contributor

dgodd commented Aug 8, 2018

This is finished on develop branch. I am waiting on rebuilds of docker images to merge to master

@ekcasey
Copy link
Member Author

ekcasey commented Aug 15, 2018

Merged to master.

@ekcasey ekcasey closed this as completed Aug 15, 2018
@ekcasey ekcasey reopened this Aug 16, 2018
@ekcasey
Copy link
Member Author

ekcasey commented Aug 16, 2018

Setup

  1. install yj - go get github.com/sclevine/yj
  2. install yj - go install github.com/sclevine/yj
  3. make sure docker daemon is running

Acceptance steps

  1. clone buildpack/packs
  2. int the packs repo run v3/bin/build ubuntu:18.04 master
  3. clone buildpack/pack
  4. in pack repo dep ensure
  5. in pack repo go build ./cmd/pack/
  6. pack build -d -p <path-to-node-app> <image-name>
  7. docker images and see in the list
  8. docker run -e PORT=8000 -p 8000:8000 <image-name>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/enhancement Issue that requests a new feature or improvement.
Projects
None yet
Development

No branches or pull requests

3 participants