-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generate checksums during package #679
Conversation
Signed-off-by: Yael Harel <[email protected]>
cfd1fc3
to
6519163
Compare
Notes:
I can add the file name to the file itself but I don't think it's necessary because the user can see it from the file name itself. |
Signed-off-by: Yael Harel <[email protected]>
Signed-off-by: Yael Harel <[email protected]>
The Github Actions part was tested on my fork: |
Signed-off-by: Yael Harel <[email protected]>
Verified with https://github.com/yaelharel/lifecycle/releases/tag/v0.99999.0 (LOL version I think the pack .sha256 files have that formatting because they're using Worth noting that we'll be using new tags for the linux x86-64 lifecycle image (
|
I like adding a newline. It is what I've seen more often than not. I have also seen a single
I don't have a strong opinion on this though. As long as the hash is somewhere I'm confident the users who intend to verify will find a way :) |
@natalieparellano @jabrown85, thanks for your feedback.
I slightly prefer having a separate sha file for every os, so I'm going to add the newline as you requested. |
Signed-off-by: Yael Harel <[email protected]>
4da9707
to
caaeff2
Compare
@natalieparellano @jabrown85, please see caaeff2 for the new line addition. |
Fixes #674.