Change defaults that are depending on the working dir to be under <layers> #454
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…yers> Notes: * This commit introduces platfromAPI 0.5 as a supported API. * The changes apply only for platformAPI >= 0.5. * The path of the relevant files is being changed as part of Args after parsing the flags. * Allow the user to set the layers flag in the detector. Signed-off-by: Yael Harel <[email protected]>
yaelharel
commented
Oct 29, 2020
yaelharel
commented
Oct 29, 2020
ekcasey
requested changes
Oct 30, 2020
There was a problem hiding this comment.
Although we don't think we need to acceptance test every affected flag I think having at least one acceptance test that uses a default relative to layers dir would be good.
This analyzer test seems like a good candidate https://github.com/buildpacks/lifecycle/blob/main/acceptance/analyzer_test.go#L162-L178
It should pass now even if you remove the -analyzed flag. If we alter that test we should add another test that sets -analyzed but not -layers, to ensure both cases work.
* Need to fix a new test in analyzer_test.go Signed-off-by: Yael Harel <[email protected]>
yaelharel
commented
Nov 7, 2020
|
@ekcasey, I pushed a commit with some fixes following your feedback. Please ignore it for now and I'll push a fix as soon as possible. |
Signed-off-by: Yael Harel <[email protected]>
yaelharel
force-pushed
the
393-defaults-layers
branch
from
6cc0489
to
a989e4f
Compare
yaelharel
commented
Nov 10, 2020
ekcasey
requested changes
Nov 10, 2020
added 2 commits
November 10, 2020 22:36
Signed-off-by: Yael Harel <[email protected]>
Signed-off-by: Yael Harel <[email protected]>
yaelharel
commented
Nov 12, 2020
ekcasey
approved these changes
Nov 12, 2020
Signed-off-by: Yael Harel <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notes:
Fixes #393