Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When setting up buildpack env, process layers for a given buildpack in alphabetical order #1394

Merged
merged 1 commit into from
Aug 20, 2024

Conversation

natalieparellano
Copy link
Member

Summary

When setting up buildpack env, process layers for a given buildpack in alphabetical order

Release notes

When setting up buildpack env, process layers for a given buildpack in alphabetical order


Related

Resolves #1393


Context

@natalieparellano natalieparellano marked this pull request as ready for review August 20, 2024 17:11
@natalieparellano natalieparellano requested a review from a team as a code owner August 20, 2024 17:11
@natalieparellano
Copy link
Member Author

@edmorley this seems like it should work but I haven't had a chance to try it with your repro. If there's any way you could test it out with the artifacts from https://github.com/buildpacks/lifecycle/actions/runs/10475874289 (when available) that could help us move faster.

Copy link
Contributor

@edmorley edmorley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you - this resolved the issue when I tested locally :-)

@natalieparellano natalieparellano merged commit 2e76236 into main Aug 20, 2024
8 checks passed
@natalieparellano natalieparellano deleted the fix/build-env-var-order branch August 20, 2024 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Layer env vars are not processed in layer name order at build time
3 participants