Skip to content

Commit

Permalink
Report image name when restorer fails to pull (#1174)
Browse files Browse the repository at this point in the history
Report the image name so end-users can take some action.

Signed-off-by: Aidan Delaney <[email protected]>
  • Loading branch information
AidanDelaney authored Aug 3, 2023
1 parent f8b3419 commit 7001b6a
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions cmd/lifecycle/restorer.go
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@ func (r *restoreCmd) Exec() error {
cmd.DefaultLogger.Debugf("Pulling builder image metadata for %s...", r.BuildImageRef)
remoteBuildImage, err := r.pullSparse(r.BuildImageRef)
if err != nil {
return cmd.FailErr(err, "pull builder image")
return cmd.FailErr(err, fmt.Sprintf("pull builder image %s", remoteBuildImage.Name()))
}
digestRef, err := remoteBuildImage.Identifier()
if err != nil {
Expand All @@ -106,7 +106,7 @@ func (r *restoreCmd) Exec() error {
cmd.DefaultLogger.Debugf("Pulling run image metadata for %s...", runImageName)
remoteRunImage, err = r.pullSparse(runImageName)
if err != nil {
return cmd.FailErr(err, "pull run image")
return cmd.FailErr(err, fmt.Sprintf("pull run image %s", remoteRunImage.Name()))
}
// update analyzed metadata, even if we only needed to pull the image metadata, because
// the extender needs a digest reference in analyzed.toml,
Expand All @@ -118,7 +118,7 @@ func (r *restoreCmd) Exec() error {
cmd.DefaultLogger.Debugf("Updating run image info in analyzed metadata...")
remoteRunImage, err = remote.NewImage(runImageName, r.keychain)
if err != nil || !remoteRunImage.Found() {
return cmd.FailErr(err, "pull run image")
return cmd.FailErr(err, fmt.Sprintf("pull run image %s", remoteRunImage.Name()))
}
if err = updateAnalyzedMD(&analyzedMD, remoteRunImage); err != nil {
return cmd.FailErr(err, "update analyzed metadata")
Expand Down

0 comments on commit 7001b6a

Please sign in to comment.