Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for working-directory in launch.toml (API>=0.8) #133

Merged
merged 2 commits into from
Apr 5, 2022

Conversation

gcemaj
Copy link

@gcemaj gcemaj commented Apr 5, 2022

Add support for working directory setting in launch.toml

If API is not 0.8 then log that this setting will be ignored, and reset working directory to be blank. Otherwise ensure that the setting is propagated.

Closes #127

@gcemaj gcemaj changed the title [action] add working-directory to launch.toml (API>=0.8) Add working-directory to launch.toml (API>=0.8) Apr 5, 2022
@gcemaj gcemaj changed the title Add working-directory to launch.toml (API>=0.8) Add support for working-directory in launch.toml (API>=0.8) Apr 5, 2022
@sambhav sambhav added type:enhancement A general enhancement semver:minor A change requiring a minor version bump labels Apr 5, 2022
@gcemaj gcemaj force-pushed the gcemaj-launch-working-dir branch from ad0e745 to 8833a22 Compare April 5, 2022 18:25
build_test.go Outdated Show resolved Hide resolved
build.go Show resolved Hide resolved
@gcemaj gcemaj force-pushed the gcemaj-launch-working-dir branch from 8833a22 to 0720848 Compare April 5, 2022 19:06
@gcemaj gcemaj force-pushed the gcemaj-launch-working-dir branch from 0720848 to 5c5fb9c Compare April 5, 2022 19:08
@gcemaj gcemaj requested review from dmikusa and sambhav April 5, 2022 19:14
@sambhav sambhav merged commit 71c0efa into buildpacks:main Apr 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver:minor A change requiring a minor version bump type:enhancement A general enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support Buildpacks API 0.8: working directory per process
3 participants