Validation should only occur under API 0.7 #108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Adds API checks before validating SBOM format, should only happen with API 0.7+ - Adds a test to confirm validation does not run if the API is less than 0.7. Resolves #107 Signed-off-by: Daniel Mikusa <[email protected]>
dmikusa
added
type:bug
sambhav
reviewed
Jan 10, 2022
| if err := validateSBOMFormats(ctx.Layers.Path, ctx.Buildpack.Info.SBOMFormats); err != nil { | ||
| config.exitHandler.Error(fmt.Errorf("unable to validate SBOM\n%w", err)) | ||
| return | ||
| if API != "0.1" && API != "0.2" && API != "0.3" && API != "0.4" && API != "0.5" && API != "0.6" { |
There was a problem hiding this comment.
Shall we just check if api == 0.7 for now? we can add semver parsing later.
There was a problem hiding this comment.
I went with this approach because it is future proof and doesn't need changing in the future. It is very ugly though.
I'm not opposed to just matching on 0.7, but I worry that'll cause something to break in the future.
+100 for better API matching. That should be a target for v2. We should also look at some possible patterns for coding multiple version support in sane ways. IMHO, having If version == xyz blocks all over is hard to maintain. There's got to be something better we can do there for v2.
sambhav
approved these changes
Jan 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #107
Signed-off-by: Daniel Mikusa [email protected]