Increase timeouts for actions that rely on actions #214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Josh W Lewis <[email protected]>
joshwlewis
force-pushed
the
increase-add-entry-timeout
branch
from
78e33ea to
4ad31e1
Compare
joshwlewis
added
semver:patch
|
@hone I don't suppose you have access to this repo and could review? :-) |
jkutner
approved these changes
Jul 18, 2023
edmorley
added a commit
to heroku/languages-github-actions
that referenced
this pull request
Jul 19, 2023
Dependabot can currently only update standard actions, not those that use a Docker Hub reference - so this Docker Hub reference has to be updated manually. The upstream `request-add-entry` action has a number of fixes we should pick up: buildpacks/github-actions@v5.0.1...v5.3.0 Most notably: - buildpacks/github-actions#198 - buildpacks/github-actions#214 GUS-W-13788681.
edmorley
added a commit
to heroku/languages-github-actions
that referenced
this pull request
Jul 20, 2023
Dependabot can currently only update standard actions, not those that use a Docker Hub reference - so this Docker Hub reference has to be updated manually. The upstream `request-add-entry` action has a number of fixes we should pick up: buildpacks/github-actions@v5.0.1...v5.3.0 Most notably: - buildpacks/github-actions#198 - buildpacks/github-actions#214 Fixes #68. GUS-W-13788681.
edmorley
added a commit
to edmorley/github-actions
that referenced
this pull request
Jul 4, 2024
In buildpacks#214 the timeouts for Actions that rely on other Actions was bumped from 2 minutes to 8 minutes. However, there are still occasionally instances where the registry request issue isn't processed for up to 15-16 minutes due to delays in the GitHub Actions runner being started. As such this raises the timeout again, from 8 minutes to 20 minutes. Signed-off-by: Ed Morley <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
registry/request-add-buildpackandregistry/request-yank-buildpackactions both rely on a synchronous check to ensure that the issue opened is also closed. The issue is only closed after the GitHub actions automation onbuildpacks/registry-indexfinishes. However, it seems fairly common to see some instance queuing in GitHub actions. This PR changes the timeout for these actions to give a bit more time for the registry operations to complete.Some examples of slower entries:
registry/request-add-entrywith the default timeout of 2 minutes would have timed out for all of the above (in fact, one of mine did here: https://github.com/heroku/buildpacks-nodejs/actions/runs/5049524949/jobs/9059646026). I've increased the timeout to be just above the slowest of recent releases.