Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added vale linter in github actions #704

Merged
merged 14 commits into from
Jul 17, 2024
Merged

Added vale linter in github actions #704

merged 14 commits into from
Jul 17, 2024

Conversation

officialasishkumar
Copy link
Contributor

Resolves #699

@officialasishkumar officialasishkumar requested a review from a team as a code owner May 3, 2024 11:52
@AidanDelaney
Copy link
Member

This looks to be a great idea. I need to look into vale a bit more. Should we also enable https://vale.sh/docs/topics/packages/#config-only ?

@natalieparellano
Copy link
Member

It would be awesome if we could add this. Vale seems to be recommended widely in the Write the Docs Slack instance.

AidanDelaney
AidanDelaney approved these changes Jul 17, 2024
View reviewed changes
Copy link
Member

@AidanDelaney AidanDelaney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. We can push it into non-strict mode if it discourages any contributors

@AidanDelaney AidanDelaney merged commit 25ebfe8 into buildpacks:main Jul 17, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AidanDelaney AidanDelaney AidanDelaney approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Vale linter for doc quality checks
3 participants
@officialasishkumar @AidanDelaney @natalieparellano