#66: Should work without CSS in modern browsers (closes #66) #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
giogonzo
reviewed
Jul 2, 2018
There was a problem hiding this comment.
Looks 💯!
(unrelated to this pr) Are any of the "known issues" with IE11 here https://caniuse.com/#feat=flexbox worth a warning?
src/FlexView.tsx
Outdated
| justifyContent: alignPropToFlex(column ? vAlignContent : hAlignContent), | ||
| alignItems: alignPropToFlex(column ? hAlignContent : vAlignContent), | ||
|
|
||
| // style passed throw props |
src/FlexView.tsx
Outdated
| const style = this.getStyle(); | ||
| const props = omit(this.props, Object.keys(FlexView.propTypes)); | ||
| return ( | ||
| <div className={className} style={style} {...props}> | ||
| <div className={`react-flex-view ${this.props.className || ''}`.trim()} style={style} {...props}> |
There was a problem hiding this comment.
Are you leaving the class to be slightly less breaking or some other reason?
There was a problem hiding this comment.
yes, I think we are relying on that class in some projects... for modern browsers this PR should not be breaking (apart from removing the import of the no longer existing SASS)
giogonzo
approved these changes
Jul 2, 2018
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #66
Test Plan
tests performed
tests not performed (domain coverage)