Refactor queue creation and attribute handling #100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit introduces changes to the `Create` method of the `Queue` struct, improving the flexibility and configurability of queue attributes. The following updates were made: - The `queuePolicy` now supports customization through a configuration file located at `/etc/lifecycled/queue_policy.json`. If the file is not found or cannot be read, a default policy is used. - The `Create` method now checks for the presence of environment variable `KMS_MASTER_KEY_ID`. If available, it sets the corresponding attribute in the SQS queue creation request. - The error handling in attribute assignment has been enhanced, ensuring proper handling of errors related to environment variable parsing and conversion. These changes improve the modularity and adaptability of the code, allowing for easier customization of queue policies and attribute configurations. They provide a more seamless integration with environment variables, offering greater flexibility in different deployment scenarios. These modifications enhance the maintainability and configurability of the codebase, ensuring a more robust and adaptable queue management solution.
|
Sorry I pushed the wrong commit |
This commit introduces changes to the `Create` method of the `Queue` struct, improving the flexibility and configurability of queue attributes. The following updates were made: - The `queuePolicy` now supports customization through a configuration file located at `/etc/lifecycled/queue_policy.json`. If the file is not found or cannot be read, a default policy is used. - The `Create` method now checks for the presence of environment variable `KMS_MASTER_KEY_ID`. If available, it sets the corresponding attribute in the SQS queue creation request. - The error handling in attribute assignment has been enhanced, ensuring proper handling of errors related to environment variable parsing and conversion. These changes improve the modularity and adaptability of the code, allowing for easier customization of queue policies and attribute configurations. They provide a more seamless integration with environment variables, offering greater flexibility in different deployment scenarios. These modifications enhance the maintainability and configurability of the codebase, ensuring a more robust and adaptable queue management solution.
|
Hi @ashkankamyab, sorry for the slow response. We had a look and have two main suggestions:
Please let us know how much of a blocker this is for you, so we can give the right amount of help to get this merged! |
|
Hi Sorry for delay. I was stucked in my daily tasks. I will fix it asap :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit introduces changes to the
Createmethod of theQueuestruct, improving the flexibility and configurability of queue attributes. The following updates were made:queuePolicynow supports customization through a configuration file located at/etc/lifecycled/queue_policy.json. If the file is not found or cannot be read, a default policy is used.Createmethod now checks for the presence of environment variableKMS_MASTER_KEY_ID. If available, it sets the corresponding attribute in the SQS queue creation request.These changes improve the modularity and adaptability of the code, allowing for easier customization of queue policies and attribute configurations. They provide a more seamless integration with environment variables, offering greater flexibility in different deployment scenarios.
These modifications enhance the maintainability and configurability of the codebase, ensuring a more robust and adaptable queue management solution.