Add support for additional ARM/Graviton instance types, reprise #981
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To get around Cloudformation's `!Or` 10 parameter limit.
|
🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a retry of #969 and supersedes it – the problem encountered there is that the CloudFormation intrinsic function
!Orcan only take between minimum 2 and maximum 10 arguments.To address that issue i've perpetrated a bit of a hack, but it works. Basically, split the conditional into a sub-clause for each instance family.
I don't recall if it's possible to switch base branch in already-created PRs, so here's a fresh one. Apologies to the authors of the previous one – feel free to cherry-pick my changes if you prefer to keep the original PR open.