Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add signing verification behaviour and fix windows config option #1370

Merged
merged 2 commits into from
Sep 13, 2024

Conversation

wolfeidau
Copy link
Contributor

This also fixes a misconfiguration on the windows agent.

This setting is critical to rolling out signing as it is helpful during migration if you want to enable warn mode while updating pipelines.

This setting determines the Buildkite agent's response when it receives a job without a proper signature, and also specifies how strictly the agent should enforce signature verification for incoming jobs. The agent will warn about missing or invalid signatures, but will still proceed to execute the job. If not explicitly specified, the default behavior is block, which prevents any job without a valid signature from running, ensuring a secure pipeline environment by default.

@wolfeidau wolfeidau force-pushed the add_verification_failure_behaviour branch from 882c821 to 6556d90 Compare September 12, 2024 04:48
@wolfeidau wolfeidau changed the title To close out the signing feature I have added verification behaviour Add signing verification behaviour and fix windows config option Sep 12, 2024
templates/aws-stack.yml Outdated Show resolved Hide resolved
@wolfeidau wolfeidau force-pushed the add_verification_failure_behaviour branch from 6556d90 to 76e1201 Compare September 12, 2024 06:07
Copy link
Contributor

@DrJosh9000 DrJosh9000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wolfeidau wolfeidau merged commit 78c3964 into main Sep 13, 2024
1 check passed
@wolfeidau wolfeidau deleted the add_verification_failure_behaviour branch September 13, 2024 00:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants