Improve logging for startup scripts on linux #1230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
triarius
force-pushed
the
pdp-1587-clearer-logs-in-buildkiteelastic-stack-log-group
branch
from
fd394a8
to
ff9c649
Compare
The command that sends the scripts output streams to the loggers merges stdout and stderr anyway, so there is no point in writing to stderr in the script. This is the logging command: ``` exec > >(tee -a /var/log/elastic-stack.log | logger -t user-data -s 2>/dev/console) 2>&1 ``` it is present in each of these scripts.
triarius
force-pushed
the
pdp-1587-clearer-logs-in-buildkiteelastic-stack-log-group
branch
from
ff9c649
to
e8184d8
Compare
triarius
deleted the
pdp-1587-clearer-logs-in-buildkiteelastic-stack-log-group
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this PR, the startup scripts had tracing enabled (set -x) which made them difficult to read. This PR disables tracing and adds manual logging to the startup scripts.
I've tried to log before performing an action, and log if it fails. If a file is written to, I also try to log what was written. If you compare the output of these logs (the cloudwatch log group
/buildkite/elastic-stack/<instance-id>) before an after this PR, the after has more information and is easier to follow (IMO).Screenshots
Before
After
I've also removed some use of
>&2, see e8184d8.