Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docker #1011

Merged
merged 1 commit into from
Apr 26, 2022
Merged

Update docker #1011

merged 1 commit into from
Apr 26, 2022

Conversation

moskyb
Copy link
Contributor

@moskyb moskyb commented Apr 22, 2022

Linux: 20.10.9 -> 20.10.14
Windows: 20.10.7 -> 20.10.9

We can't use the same version of docker across both linux and windows because our method of installing docker on windows is no longer supported, and isn't being updated with new versions. We'll need to properly fix this in time, but for now, we also need to update docker versions for the elastic stack

Fixes PIP-434

Linux: 20.10.9 -> 20.10.14
Windows: 20.10.7 -> 20.10.9
@benesch
Copy link

benesch commented Apr 26, 2022

Would be swell to get this merged! We're running into a bug in Docker v20.10.9 that's fixed in v20.10.10: MaterializeInc/materialize#12017.

Anything we can do to help?

Copy link

@jordandcarter jordandcarter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌

@moskyb moskyb merged commit a4cd027 into master Apr 26, 2022
@moskyb moskyb deleted the update-docker branch April 26, 2022 21:06
@moskyb
Copy link
Contributor Author

moskyb commented Apr 26, 2022

@benesch i'll try to get this out in a patch release later today :)

@benesch
Copy link

benesch commented Apr 26, 2022

Awesome, thanks very much @moskyb!

@moskyb
Copy link
Contributor Author

moskyb commented Apr 27, 2022

@benesch this is in the process of being released as v5.8.2. It should finish building in half an hour or so :)

@benesch
Copy link

benesch commented Apr 28, 2022

Thanks very much, @moskyb! Worked like a charm.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants