Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AWS Lambda end of support for the Go 1.x runtime #108

Merged
merged 4 commits into from
Oct 12, 2023

Conversation

HugeIRL
Copy link
Contributor

@HugeIRL HugeIRL commented Oct 12, 2023

The go1.x runtime is being deprecated in favour of the provided.al2 runtime, see this post for background.

We implemented the steps in the blog post the following PR #103 however, at the time the library AWS-Lambda-Go was at an old version that was incompatible with the provided.al2 runtime. After the runtime was upgraded in #107 the changes in this PR should make the scaler work with provided.al2 lambda runtime.

Fixes: #101

Copy link
Contributor

@triarius triarius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing work!

@triarius triarius merged commit 7127e08 into buildkite:master Oct 12, 2023
2 checks passed
@jenniferhopwood
Copy link

@HugeIRL Thanks so much for your amazing efforts in getting this out. 🙇‍♀️

Will there be a timeline for update of the S3 bucket latest link with the updated v1.7.0 version for BuildkiteAgentScalerVersion param?

@HugeIRL
Copy link
Contributor Author

HugeIRL commented Oct 18, 2023

@jenniferhopwood I appreciate that, thank you!

We still have some final touches and fixes to do, so once that is done it'll be updated. At the moment no timeline yet, but we are actively working on it! :)

@triarius
Copy link
Contributor

triarius commented Oct 19, 2023

@jenniferhopwood you can use this with the currently released version of the Elastic CI Stack by setting the BuildkiteAgentScalerVersion parameter to 1.7.0.

Edit: I tried this out in the UI, and it didn't seem to work. I then used aws cloudfromation update-stack and it did. Looks similar to buildkite/elastic-ci-stack-for-aws#1172 (comment).

TL;DR use aws cloudformation update-stack to update your stacks.

@triarius
Copy link
Contributor

In any case, it's released with v6.8.0 of the Elastic CI Stack.

@jenniferhopwood
Copy link

I had considered passing in 1.7.0 value but decided to wait before I locked down my versions.
Thanks so much @triarius and @HugeIRL for actioning this we have deployed this version last weekend and this has unblocked us for many of our code scanning tools and improved our AWS Trusted Advisor status.
Much appreciated. 🙇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AWS Lambda end of support for the Go 1.x runtime
3 participants